Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md: Added note about how to post JSON #198

Merged
merged 1 commit into from
Aug 3, 2017
Merged

README.md: Added note about how to post JSON #198

merged 1 commit into from
Aug 3, 2017

Conversation

perlun
Copy link
Contributor

@perlun perlun commented Aug 2, 2017

Credits go to Jason Worley who wrote about this on his blog

(I cleaned up some string quote characters at the same time.)

@perlun
README.md: Added note about how to post JSON
5867472 
Credits go to Jason Worley who wrote about this on [his blog](http://jasonincode.com/rack_test_and_json/)
@perlun perlun self-assigned this Aug 2, 2017
@perlun perlun requested review from junaruga and dennissivia August 2, 2017 12:56
dennissivia
dennissivia approved these changes Aug 2, 2017
View reviewed changes
Copy link

@dennissivia dennissivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

junaruga
junaruga approved these changes Aug 2, 2017
View reviewed changes
Copy link
Contributor

@junaruga junaruga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found your modified document.
https://github.com/rack-test/rack-test/blob/perlun-patch-1/README.md

It looks good to me.
Thanks.
By the way, I prefer you to create new branch for your repository rather than rack-test/rack-test repository, if you do not mind it.
Because we have to mind cleaning unused branches.

@perlun
Copy link
Contributor Author

perlun commented Aug 3, 2017

By the way, I prefer you to create new branch for your repository rather than rack-test/rack-test repository, if you do not mind it.
Because we have to mind cleaning unused branches.

Sure, that's fine. The problem is that the GitHub web editor creates a branch in this repo if you edit the file online, since all of us have write access to the repo. I don't know if that setting can be changed, but it is what caused this to happen.

Regarding deleting the branch: that's fine, I will press the Delete button now right after merging it. 😄

@perlun perlun merged commit 49c27b5 into master Aug 3, 2017
@perlun perlun deleted the perlun-patch-1 branch August 3, 2017 05:14
@junaruga junaruga mentioned this pull request Nov 6, 2017
Closed
alex-damian-negru pushed a commit to alex-damian-negru/rack-test that referenced this pull request Apr 5, 2021
@perlun
README.md: Added note about how to post JSON (rack#198)
e4aa5d6 
Credits go to Jason Worley who wrote about this on [his blog](http://jasonincode.com/rack_test_and_json/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennissivia dennissivia dennissivia approved these changes

@junaruga junaruga junaruga approved these changes

Assignees

@perlun perlun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@perlun @junaruga @dennissivia