Fix #336: Disable asynchronous mode for GTK printing. #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chihyang
changed the title
chihyang
changed the title
Fix issue racket#336: for unknown reasons, asynchronous printing in GTK3 generates blank pages. Disabling asynchronous mode fixes this problem. This change makes the main window freeze when the print dialog is popped up. But it shouldn't be a problem. First this is also the default behavior when the print dialog is popped up in Windows. This change makes the behavior more consistent on different OSes. Besides, it is reasonable to forbid editing when the contents of the editor is being printed.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #336: for unknown reasons, asynchronous printing in GTK3 generates blank pages. Disabling asynchronous mode fixes this problem. This change makes the main window freeze when the print dialog is popped up. But it shouldn't be a problem. First this is also the default behavior when the print dialog is popped up in Windows. This change makes the behavior more consistent on different OSes. Besides, it is reasonable to forbid editing when the contents of the editor is being printed.