Repair errors uncovered by racket/typed-racket#1367. #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Resyntax analyzed 0 files in this pull request and found no issues.
alex-hhh
approved these changes
Mar 30, 2024
Some arguments were not type checked correctly, meaning some type errors slipped through. The most significant change is that the jitter parameters become `Nonnegative-Real`, which is backwards-incompatible. Other choices there are possible, but this is the simplest.
There was a problem hiding this comment.
Resyntax analyzed 0 files in this pull request and found no issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some arguments were not type checked correctly, meaning some type
errors slipped through.
The most significant change is that the jitter parameters become
Nonnegative-Real, which is backwards-incompatible. Other choicesthere are possible, but this is the simplest.