Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fixes for windbg #14666

Merged
merged 1 commit into from
Jul 27, 2019
Merged

Some fixes for windbg #14666

merged 1 commit into from
Jul 27, 2019

Conversation

GustavoLCR
Copy link
Contributor

@GustavoLCR
Some fixes to windbg
5948e50 
 * Fix radareorg#10505
 * Fix wrong register profile being picked
 * Fix use-after free(s) and null derefs
@GustavoLCR GustavoLCR added the WinDbg Remote WinDbg/KD protocol support label Jul 27, 2019
@XVilka
Copy link
Contributor

XVilka commented Jul 27, 2019

LGTM.

@GustavoLCR GustavoLCR mentioned this pull request Jul 27, 2019
Closed
@codecov-io
Copy link

Codecov Report

Merging #14666 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14666      +/-   ##
==========================================
- Coverage   37.96%   37.95%   -0.01%     
==========================================
  Files         957      957              
  Lines      312398   312416      +18     
==========================================
- Hits       118591   118590       -1     
- Misses     193807   193826      +19
Impacted Files Coverage Δ
libr/debug/p/debug_windbg.c 0% <0%> (ø) ⬆️
libr/io/p/io_windbg.c 4.25% <0%> (ø) ⬆️
shlr/windbg/windbg.c 0% <0%> (ø) ⬆️
libr/core/task.c 56.85% <0%> (-0.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8328fc5...5948e50. Read the comment docs.

@XVilka XVilka merged commit 8a6a7ba into radareorg:master Jul 27, 2019
@GustavoLCR GustavoLCR deleted the win-fixes branch July 27, 2019 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
WinDbg Remote WinDbg/KD protocol support
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.

segfault when running ds with windbg plugin
3 participants
@GustavoLCR @XVilka @codecov-io