Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ljmp with immediate segment:offset #6125

Merged
merged 2 commits into from
Nov 4, 2016
Merged

Fix ljmp with immediate segment:offset #6125

merged 2 commits into from
Nov 4, 2016

Conversation

mrmacete
Copy link
Collaborator

@mrmacete mrmacete commented Nov 4, 2016

No description provided.

@radare radare merged commit a235726 into radareorg:master Nov 4, 2016
@Maijin
Copy link
Contributor

Maijin commented Nov 5, 2016

Wait, is that #36 ?

@mrmacete
Copy link
Collaborator Author

mrmacete commented Nov 5, 2016

uhm, related. yeah the last part - the $j is fixed, where capstone works. Could you point me to the existing test for #36 so that i can check what i did is spot on?

@Maijin
Copy link
Contributor

Maijin commented Nov 5, 2016

https://github.com/radare/radare2-regressions/blob/master/t.formats/firmware/bios#L30

@Maijin
Copy link
Contributor

Maijin commented Nov 5, 2016

And check also #4344 #4952

@mrmacete
Copy link
Collaborator Author

mrmacete commented Nov 5, 2016

unbroken the test: https://github.com/radare/radare2-regressions/pull/615

@mrmacete mrmacete deleted the jump-x86-16 branch November 6, 2016 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrmacete @Maijin @radare