Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print an empty JSON list when there are no xrefs #7487

Merged
merged 1 commit into from
May 13, 2017
Merged

Print an empty JSON list when there are no xrefs #7487

merged 1 commit into from
May 13, 2017

Conversation

adrianherrera
Copy link
Contributor

Instead of staying silent (which can cause an error when using r2pipe and it is expecting JSON data) print an empty list when no cross references exist to/from an address.

@radare
Copy link
Collaborator

radare commented May 13, 2017

The r2pipe backends assume empty output as an empty object or array already. Because i wanted a quick way to solve those cases that randomly happen now and then. Thanks for that pr

@radare radare merged commit b0b1c7f into radareorg:master May 13, 2017
@adrianherrera
Copy link
Contributor Author

Oh ok, I didn't realise that the r2pipe backend recognised an empty object. When I was using r2pipe in Python I got an error.

No worries!

@radare
Copy link
Collaborator

radare commented May 14, 2017

Maybe i did the change for node only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants