Skip to content

Commit

Permalink
ci: remove -X theirs from cherry-pick in checkout-pr script
Browse files Browse the repository at this point in the history
Using a merge strategy only risks confusion when the merge leads to code being removed when it shouldn‘t be. Therefore, it‘s better to report a merge conflict and have the PR author resolve it manually.
  • Loading branch information
aleclarson committed Aug 15, 2024
1 parent a8c759b commit 934632e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/checkout-pr.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ git fetch pr "$PR_HEAD_REF"

# Import changes from the PR into the current branch without committing
BASE_COMMIT=$(git merge-base HEAD "pr/$PR_HEAD_REF")
git cherry-pick -n "$BASE_COMMIT..pr/$PR_HEAD_REF" -X theirs
git cherry-pick -n "$BASE_COMMIT..pr/$PR_HEAD_REF"

# List the affected files for debugging purposes
git diff --name-status --staged

0 comments on commit 934632e

Please sign in to comment.