-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: config renovate config file #237
ci: config renovate config file #237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool! Thanks for working on it, Marlon. 👍 👍
Considering that Radashi only has dev dependencies, I wonder if it's worth the effort of upgrading them every week? Do you have a theory for this?
I know we want security updates. I found a Renovate issue where someone found a configuration that only handles security vulnerabilities (see here). So that's an option, if nothing else.
But I'm still curious about the benefits of upgrading on a regular basis. The obvious answer is “more bug fixes, more performance boosts” but those aren't always worth the attention required to checkout the Renovate PR and test it to ensure there aren't regressions, so I'm on the fence about it.
renovate.json
Outdated
"lockFileMaintenance": { | ||
"enabled": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is disabled by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a mistake, it was supposed to be activated
By default, renovate, delete the lockfiles and install the dependencies, this sounds to me like 'if I'm going to delete the lock file every time I update, it's the same as not having a lock file.
That said, I think it makes sense to keep the lock file.
https://docs.renovatebot.com/configuration-options/#lockfilemaintenance
No 😅, I put weekly because that's what came to my head at the time. That said, I think monthly might be ok for someone to have a time and check the dependencies. What do you think ?
I think it's interesting to leave this active.
Your comment made me reflect, and after some research, I found there's a discussion around how frequently dependencies should be updated. I believe neither extreme is ideal — “never updating” nor “updating constantly.” A middle ground, like monthly or semi-annual reviews, makes more sense, allowing time to check for updates. In my work, I've had negative experiences with outdated dependencies that made project evolution difficult. While this project only has development dependencies, I believe most updates generally bring significant improvements. |
Thanks a lot for setting this up 👏 😄 |
Tip
The owner of this PR can publish a preview release by commenting
/publish
in this PR. Afterwards, anyone can try it out by runningpnpm add radashi@pr<PR_NUMBER>
.Summary
Create the config file to integrate the project with renovate.
Related issue, if any:
https://github.com/orgs/radashi-org/discussions/170
For any code change,
Does this PR introduce a breaking change?
No