Handle nested BaseSettings without nested delimiter #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mssalvatore
force-pushed
the
handle-nested-settings-models
branch
2 times, most recently
from
b435d4d to
4ffa4aa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 177 183 +6
Branches 48 50 +2
=========================================
+ Hits 177 183 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mssalvatore
force-pushed
the
handle-nested-settings-models
branch
from
4ffa4aa to
d8e4526
Compare
|
@radeklat Hey! I'm wondering if there's anything I can do to grease the skids on this PR. Thanks in advance! |
mssalvatore
force-pushed
the
handle-nested-settings-models
branch
from
d8e4526 to
32fadc6
Compare
radeklat
requested changes
Sep 17, 2024
mssalvatore
force-pushed
the
handle-nested-settings-models
branch
3 times, most recently
from
cc7f771 to
1c725bc
Compare
mssalvatore
force-pushed
the
handle-nested-settings-models
branch
from
1c725bc to
f73eb3b
Compare
mssalvatore
force-pushed
the
handle-nested-settings-models
branch
from
f73eb3b to
120fda2
Compare
radeklat
approved these changes
Sep 19, 2024
|
Thanks, @radeklat! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36