Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Best practice headings and reorg #1010

Merged
merged 3 commits into from
Feb 24, 2021
Merged

Best practice headings and reorg #1010

merged 3 commits into from
Feb 24, 2021

Conversation

cholmes
Copy link
Contributor

@cholmes cholmes commented Feb 24, 2021

Related Issue(s): #1006

Proposed Changes:

  1. Did a bit of reorganizing of the best practice document, and put more groupings, so it's a bit more broken up.

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • a CHANGELOG entry is not required.

@cholmes cholmes added this to the 1.0.0-RC.1 milestone Feb 24, 2021
@cholmes cholmes linked an issue Feb 24, 2021 that may be closed by this pull request
Group best practice sections #1006
Closed
m-mohr
m-mohr reviewed Feb 24, 2021
View reviewed changes
best-practices.md Outdated Show resolved Hide resolved
m-mohr
m-mohr approved these changes Feb 24, 2021
View reviewed changes
Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but have one minor request for change.

@m-mohr m-mohr mentioned this pull request Feb 24, 2021
Closed
@cholmes cholmes merged commit 1a96124 into dev Feb 24, 2021
@cholmes cholmes deleted the best-practice-org branch February 24, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-mohr m-mohr m-mohr approved these changes

@lossyrob lossyrob lossyrob approved these changes

@matthewhanson matthewhanson matthewhanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-RC.1
Development

Successfully merging this pull request may close these issues.

Group best practice sections
4 participants
@cholmes @matthewhanson @lossyrob @m-mohr