Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minLength requirement to required strings (core only) #1048 #1065

Merged
merged 3 commits into from
Mar 30, 2021
Merged

Add minLength requirement to required strings (core only) #1048 #1065

merged 3 commits into from
Mar 30, 2021

Conversation

m-mohr
Copy link
Collaborator

@m-mohr m-mohr commented Mar 29, 2021

Related Issue(s): #1048

Proposed Changes:

  1. Add minLength requirement to required strings as discussed in Prevent empty strings for required fields #1048

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec, and I have opened issue/PR #XXX to track the change.

@m-mohr m-mohr requested a review from matthewhanson as a code owner March 29, 2021 16:02
@m-mohr m-mohr changed the base branch from master to dev March 29, 2021 16:02
@m-mohr m-mohr linked an issue Mar 29, 2021 that may be closed by this pull request
Prevent empty strings for required fields #1048
Closed
@m-mohr m-mohr added this to the 1.0.0-rc.2 milestone Mar 29, 2021
@m-mohr m-mohr requested a review from cholmes March 29, 2021 16:03
philvarner
philvarner reviewed Mar 30, 2021
View reviewed changes
item-spec/item-spec.md Outdated Show resolved Hide resolved
@matthewhanson matthewhanson merged commit 09712ff into dev Mar 30, 2021
@matthewhanson matthewhanson deleted the minlength-for-required-strings branch March 30, 2021 16:54
@schwehr schwehr mentioned this pull request Apr 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philvarner philvarner philvarner left review comments

@matthewhanson matthewhanson matthewhanson approved these changes

@cholmes cholmes cholmes approved these changes

Assignees
No one assigned
Labels
json schema
Projects
None yet
Milestone
1.0.0-rc.2
Development

Successfully merging this pull request may close these issues.

Prevent empty strings for required fields
4 participants
@m-mohr @philvarner @cholmes @matthewhanson