Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified stac_extensions #1078

Merged
merged 5 commits into from
Apr 15, 2021
Merged

Clarified stac_extensions #1078

merged 5 commits into from
Apr 15, 2021

Conversation

m-mohr
Copy link
Collaborator

@m-mohr m-mohr commented Mar 31, 2021

Related Issue(s): #1077

Proposed Changes:

  1. For context see stac_extensions and summaries #1077, but it basically makes it more consistent that stac_extensions also allow to list extensions that are used in collection summaries.
  2. Re-phrased the stac_extensions description in all specs.
  3. Removed the wording around "multiple affected parts" as that should be clear from each individual stac_extensions description, which requires to list stac_extensions if they are implemented. That was mostly for the commons extension back in the days, but nowadays had no real good example anymore. The data cube example in collections for example was not really correct.

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec, and I have opened issue/PR #XXX to track the change.

@m-mohr m-mohr linked an issue Mar 31, 2021 that may be closed by this pull request
@m-mohr m-mohr added this to the 1.0.0-rc.3 milestone Mar 31, 2021
@emmanuelmathot
Copy link
Collaborator

emmanuelmathot commented Mar 31, 2021

Shouldn't we add in the collection spec a clarification that explains that stac_extensions in collection should not declare extensions fields that are only summarized as in example collection https://github.com/radiantearth/stac-spec/blob/master/examples/collection-only/collection.json

@m-mohr
Copy link
Collaborator Author

m-mohr commented Mar 31, 2021

Good point @emmanuelmathot, although I'm not sure whether we should add extensions to stac_extensions that are summarized in colelctions or not. I think best would be to add them, but then we need to change examples.

@m-mohr
Copy link
Collaborator Author

m-mohr commented Apr 11, 2021

DON'T MERGE YET!

We should still discuss, whether summaries should have an influence on stac_extensions or not.

@m-mohr
Copy link
Collaborator Author

m-mohr commented Apr 15, 2021

Agreed on it for future-proofness etc.

@m-mohr m-mohr merged commit 2142d4b into dev Apr 15, 2021
@m-mohr m-mohr deleted the rephrase-stac-extensions branch April 15, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stac_extensions and summaries
5 participants