Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common metadata: Clarify in descriptions that the fields are not Item-only #1234

Merged
merged 7 commits into from
Nov 20, 2023

Conversation

m-mohr
Copy link
Collaborator

@m-mohr m-mohr commented Jun 6, 2023

Related Issue(s): None

Proposed Changes:

  1. Common metadata: Clarify in various field descriptions that the fields do not only apply to Items

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG
    or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec,
    and I have opened issue/PR #XXX to track the change.

@m-mohr m-mohr added this to the 1.1 milestone Jun 6, 2023
Copy link
Collaborator

@constantinius constantinius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This clarifies the usage of common metadata fields to not only apply to Items. Is there perhaps a chance to put this document into a more central location (like common/)? Or at least add links from the catalog and collection specs?

@m-mohr
Copy link
Collaborator Author

m-mohr commented Jun 6, 2023

I prefer the links from catalog/collection, as many other documents outside of the repo point to the file and we don't want to break these.

@m-mohr m-mohr requested a review from philvarner September 27, 2023 02:40
item-spec/common-metadata.md Outdated Show resolved Hide resolved
item-spec/common-metadata.md Outdated Show resolved Hide resolved
@m-mohr m-mohr merged commit 68fe319 into dev Nov 20, 2023
@m-mohr m-mohr deleted the common-clarification branch November 20, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants