Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON Schemas #832

Merged
merged 9 commits into from
Jun 4, 2020
Merged

Fix JSON Schemas #832

merged 9 commits into from
Jun 4, 2020

Conversation

m-mohr
Copy link
Collaborator

@m-mohr m-mohr commented Jun 3, 2020

Related Issue(s): None

Proposed Changes:

  1. Fix several issues found in JSON Schemas

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec, and I have opened issue/PR #XXX to track the change.

@m-mohr m-mohr added this to the 1.0.0-beta.2 milestone Jun 3, 2020
@cholmes
Copy link
Contributor

cholmes commented Jun 3, 2020

Seems like we'll need a beta.2 soon, so people can use schemas that work?

@m-mohr
Copy link
Collaborator Author

m-mohr commented Jun 3, 2020

Now that I have validation working I'm going to check all examples and schemas, that will take some time. But yes, validation doesn't quite work in beta.1. Why do we only find those things just a day after the release?!

@cholmes
Copy link
Contributor

cholmes commented Jun 3, 2020

Yeah, we feel a bit cursed lately. I'd say we should be checking everything before, but I think the point of the beta1 release is actually to really start on that. But we should build up more checks / infrastructure. Validate every example, and indeed I think we should shift to making sure the validator and core libraries are updated during the 'release candidate' process, even if that means longer release candidates.

Thanks for catching it early and working on it @m-mohr

@m-mohr
Copy link
Collaborator Author

m-mohr commented Jun 3, 2020

Well, tooling and some more reviewers are missing to check beforehand, I think. Most tooling unfortunately isn't (logically, it's Open Source) always keeping up with the pace. I should be getting better with the 1.0.0 releases. I guess I could release my validator and easily put it in CI for now. It already checks all examples + extension schemas... I'll issue another PR with examples fixes.

@m-mohr m-mohr marked this pull request as ready for review June 3, 2020 20:52
@matthewhanson
Copy link
Collaborator

I'd say we give beta1 a little time, see if there are any other issues that arise with schemas or examples, and add a bunch of examples.

@m-mohr m-mohr merged commit b4eb788 into dev Jun 4, 2020
@m-mohr m-mohr deleted the json-schemas branch June 4, 2020 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants