-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JSON Schemas #832
Fix JSON Schemas #832
Conversation
Seems like we'll need a beta.2 soon, so people can use schemas that work? |
Now that I have validation working I'm going to check all examples and schemas, that will take some time. But yes, validation doesn't quite work in beta.1. Why do we only find those things just a day after the release?! |
Yeah, we feel a bit cursed lately. I'd say we should be checking everything before, but I think the point of the beta1 release is actually to really start on that. But we should build up more checks / infrastructure. Validate every example, and indeed I think we should shift to making sure the validator and core libraries are updated during the 'release candidate' process, even if that means longer release candidates. Thanks for catching it early and working on it @m-mohr |
Well, tooling and some more reviewers are missing to check beforehand, I think. Most tooling unfortunately isn't (logically, it's Open Source) always keeping up with the pace. I should be getting better with the 1.0.0 releases. I guess I could release my validator and easily put it in CI for now. It already checks all examples + extension schemas... I'll issue another PR with examples fixes. |
I'd say we give beta1 a little time, see if there are any other issues that arise with schemas or examples, and add a bunch of examples. |
Related Issue(s): None
Proposed Changes:
PR Checklist: