adding JSON schema for pointcloud extension #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No worries @mccarthyryanc - my time to work on this has been less than zero, so it’s great to see someone else jump in! |
m-mohr
requested changes
Jun 27, 2020
There was a problem hiding this comment.
Great to see someone working on this to complete the extension schemas!
I reviewed the Schema and request some changes. There are some more general questions regarding the extension included, maybe one of you can also improve these points. Maybe @hobu can give some additional information on how the things were meant to be?
Oh and after those changes, maybe run the whole schema through https://jsonformatter.org/ for consistency.
…pdating pointcloud json schema based on PR comments.
m-mohr
approved these changes
Jun 28, 2020
There was a problem hiding this comment.
Looks good, thanks. Only thing you could still change is #861 (comment)
m-mohr
requested changes
Jun 29, 2020
Co-authored-by: Matthias Mohr <[email protected]>
m-mohr
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed there hadn't been any updates on this for a few months and thought I would give it a try (Sorry @adamsteer. If you already have something put together, I'm happy removing this PR.) I'm new to JSON schema so happy to get feedback.
One thing that I wasn't quite sure about was adding Property Dependencies on Statistics. So if a
statsobject is given, there should also be aschemaobject with the same name.Related Issue(s): #391
Proposed Changes:
PR Checklist: