Relative vs absolute link edits #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-mohr
reviewed
Jan 27, 2021
Co-authored-by: Matthias Mohr <[email protected]>
This was
linked to
issues
Feb 2, 2021
matthewhanson
approved these changes
Feb 3, 2021
schwehr
reviewed
Feb 3, 2021
best-practices.md
Outdated
| @@ -253,10 +253,10 @@ STAC version. Otherwise some behaviour of functionality may be unpredictable (e. | |||
|
|
|||
| ## Use of links | |||
|
|
|||
| The main catalog specification allows both relative and absolute links, and says that `self` links are not required, but are | |||
| The main STAC specifications allow both relative and absolute links, and says that `self` links are not required, but are | |||
There was a problem hiding this comment.
Maybe The main STAC specifications allow -> The STAC specification allows
What is meant by main? Are there other specifications in play here?
There was a problem hiding this comment.
I'll work to clarify this. Catalog, Item and Collection are all technically their own 'spec', designed to potentially use stand alone, so that's all I meant. I was changing it to not seem like it was implying just the 'catalog' spec. But I see how 'main' is confusing.
lossyrob
approved these changes
Feb 4, 2021
|
As @jbants is also using PySTAC internally, I think we can merge. |
m-mohr
reviewed
Feb 4, 2021
m-mohr
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #952 , #957
Proposed Changes:
PR Checklist: