-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roles best practice #989
Merged
Merged
Roles best practice #989
Changes from 22 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
f64fcec
new asset best practice start, reformmating
cholmes ee607d2
more formatting
cholmes e3935d3
refactoring and more roles
cholmes 38f87f5
markdown fixes
cholmes ca8ad51
Update best-practices.md
cholmes 8c49645
Update best-practices.md
cholmes 33aa0ac
Merge branch 'dev' into roles-best-practice
cholmes 0e8b3b8
reverted from best practice re-org, will do that in its own pr
cholmes 1dbc419
reorg based on comments in PR
cholmes 99a0747
Merge branch 'dev' into roles-best-practice
cholmes a870e38
Table formatting, cleanup text
cholmes 6d31c78
added best practice sections to extensions
cholmes 14310ec
cleanup
cholmes 0ad203c
clarifying the list a bit
cholmes 624a1af
SAR asset roles + water mask
emmanuelmathot b4727a4
Merge branch 'roles-best-practice' of https://github.com/radiantearth…
emmanuelmathot 5a0f606
roles updated in SAR extension
emmanuelmathot add7713
better links
cholmes 796898e
removed extraneous info from table of contents
cholmes bc6d117
Merge branch 'dev' into roles-best-practice
cholmes f184009
updates based on PRs
cholmes 83babad
typo fix
cholmes ac6201a
add mention that extension role list is definitive
cholmes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also mention their use in Extensions -- for example, we use (proprietarily) a role of
labels
on assets in Items using the Label Extension, and there's discussion of changing that spec to use this role instead of requiring the asset be named 'labels'There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Will add
labels
to the list, and mention extensions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I don't think I'll add this yet, since right now it's not actually specified in the label extension. When #1001 is complete we can add it (or it can add it to this list if we merge this one first).