Return error if create credential request is not a bad request

radius-project · Dec 20, 2022 · 4d4a3b2 · 4d4a3b2
1 parent 8a3654a
commit 4d4a3b2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/pkg/ucp/frontend/controller/credentials/aws/createorupdatecredential.go b/pkg/ucp/frontend/controller/credentials/aws/createorupdatecredential.go
@@ -51,6 +51,8 @@ func (p *CreateOrUpdateCredential) Run(ctx context.Context, w http.ResponseWrite
 		errors.Is(err, conv.ErrInvalidModelConversion) ||
 		errors.Is(err, &conv.ErrModelConversion{}) {
 		return armrpc_rest.NewBadRequestResponse(err.Error()), nil
+	} else if err != nil {
+		return nil, err
 	}
 
 	if newResource.Properties.Kind != datamodel.AWSCredentialKind {

diff --git a/pkg/ucp/frontend/controller/credentials/azure/createorupdatecredential.go b/pkg/ucp/frontend/controller/credentials/azure/createorupdatecredential.go
@@ -51,6 +51,8 @@ func (p *CreateOrUpdateCredential) Run(ctx context.Context, w http.ResponseWrite
 		errors.Is(err, conv.ErrInvalidModelConversion) ||
 		errors.Is(err, &conv.ErrModelConversion{}) {
 		return armrpc_rest.NewBadRequestResponse(err.Error()), nil
+	} else if err != nil {
+		return nil, err
 	}
 
 	if newResource.Properties.Kind != datamodel.AzureCredentialKind {