updating per comments

radius-project · Feb 28, 2024 · ed988b7 · ed988b7
1 parent 3a3e7b2
commit ed988b7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/pkg/recipes/terraform/config/providers/types.go b/pkg/recipes/terraform/config/providers/types.go
@@ -58,7 +58,9 @@ func GetRecipeProviderConfigs(ctx context.Context, envConfig *recipes.Configurat
 
 				// Retrieve configuration details from 'AdditionalProperties' property and add to the list.
 				for _, configDetails := range config {
-					configList = append(configList, configDetails.AdditionalProperties)
+					if configDetails.AdditionalProperties != nil && len(configDetails.AdditionalProperties) > 0 {
+						configList = append(configList, configDetails.AdditionalProperties)
+					}
 				}
 
 				providerConfigs[provider] = configList

diff --git a/pkg/recipes/terraform/config/providers/types_test.go b/pkg/recipes/terraform/config/providers/types_test.go
@@ -53,7 +53,7 @@ func TestGetRecipeProviderConfigs(t *testing.T) {
 					},
 				},
 			},
-			expected: map[string]any{"aws": []map[string]any{map[string]any(nil)}},
+			expected: map[string]any{"aws": []map[string]any{}},
 		},
 		{
 			desc: "provider with config",

diff --git a/pkg/recipes/terraform/config/testdata/providers-envrecipedefaultconfig.tf.json b/pkg/recipes/terraform/config/testdata/providers-envrecipedefaultconfig.tf.json
@@ -10,7 +10,6 @@
   },
   "provider": {
     "azurerm": [
-      null,
       {
         "alias": "az-paymentservice",
         "subscriptionid": 45678,
-Original file line number
+Diff line change
@@ Expand Up / @@ -53,7 +53,7 @@ func TestGetRecipeProviderConfigs(t *testing.T) { @@
     					},
     				},
     			},
-    			expected: map[string]any{"aws": []map[string]any{map[string]any(nil)}},
+    			expected: map[string]any{"aws": []map[string]any{}},
     		},
     		{
     			desc: "provider with config",
@@ Expand Down @@