Skip to content

Commit

Permalink
wip
Browse files Browse the repository at this point in the history
  • Loading branch information
nithyatsu committed Jun 2, 2023
1 parent c3d803a commit f2f8d71
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions pkg/cli/helm/radiusclient_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func Test_AddRadiusValuesOverrideWithSet(t *testing.T) {
helmChart.Values = map[string]any{}
options := &RadiusOptions{
ImageVersion: "imageversion",
Values: "rp.tag=latest,global.zipkin.url=url,global.prometheus.path=path",
Values: "rp.image=radius.azurecr.io/appcore-rp,rp.tag=latest,global.zipkin.url=url,global.prometheus.path=path",
}

err := AddRadiusValues(&helmChart, options)
Expand All @@ -82,11 +82,14 @@ func Test_AddRadiusValuesOverrideWithSet(t *testing.T) {
assert.Equal(t, o["tag"], "imageversion")
}

// validate tag for rp should have been overridden with latest
// validate image, tag for rp should have been overridden with latest
o := values["rp"].(map[string]any)
_, ok := o["tag"]
assert.True(t, ok)
assert.Equal(t, o["tag"], "latest")
_, ok = o["image"]
assert.True(t, ok)
assert.Equal(t, o["image"], "radius.azurecr.io/appcore-rp")

_, ok = values["global"]
assert.True(t, ok)
Expand Down

0 comments on commit f2f8d71

Please sign in to comment.