Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dapr installation from Radius installation #2952

Closed
emily-potyraj opened this issue Jul 15, 2022 · 1 comment · Fixed by #4857
Closed

Remove Dapr installation from Radius installation #2952

emily-potyraj opened this issue Jul 15, 2022 · 1 comment · Fixed by #4857
Assignees
Labels
dapr Related to Dapr integration

Comments

@emily-potyraj
Copy link
Contributor

emily-potyraj commented Jul 15, 2022

As part of investigation into how to lower our Radius installation time #2582
we saw that Radius install time could be significantly reduced by not including Dapr installation.
At this time, we don't use Dapr internally as part of Radius, but we're considering it for a longer term possible change.

I think we'd need to do a little investigation into what it means to remove Dapr and what we'd need to add at that time to keep a great user experience.

Right now, Dapr is commonly used with Radius. We lean into teaching people that Dapr + Radius is a "better together" way of achieving portability. So Dapr installation is one of the common environment dependencies that Radius users are going to want.

When we stop installing Dapr by default, we should probably have the guardrails in place for validating whether environment dependencies are installed: dependency validation work described in #2951

AB#4448

@rynowak
Copy link
Contributor

rynowak commented Jul 15, 2022

At this time, we don't use Dapr internally as part of Radius, but we're considering it for a longer term possible change.

I think we'd need to do a little investigation into what it means to remove Dapr and what we'd need to add at that time to keep a great user experience.

If we did take on Dapr as a dependency in Radius it needs to be firewalled from Dapr used by a user for applications (an implementation detail of Radius).

So, I don't think we should factor whether Radius uses Dapr into our decision. Dapr should be an optional component from the user's POV. If we were take responsibility for installing/managing Dapr for production use that's a huge deal 😆

When we stop installing Dapr by default, we should probably have the guardrails in place for validating whether environment dependencies are installed: dependency validation work described in #2951

Yes 100%. To treat Dapr as an optional component we need to design how users describe it to the environment, and how we implement guardrails for the user.

@AaronCrawfis AaronCrawfis added the dapr Related to Dapr integration label Sep 1, 2022
@Reshrahim Reshrahim changed the title remove Dapr installation from Radius installation Remove Dapr installation from Radius installation Oct 18, 2022
rynowak added a commit that referenced this issue Dec 13, 2022
Part of: #2952

This change validates the installation status of Dapr inside links RP
for Dapr resources. This is step one in removing Dapr from Radius'
default installation. After we have a good experience with Dapr missing,
we can remove it.

This validation is only applied on PUT calls to be more friendly to API
consumers. We still allow clients to get and list dapr link resources
without Dapr installed.

The pattern I followed is similar to the validation we perform for the
AKV CSI driver.
@rynowak rynowak self-assigned this Dec 13, 2022
rynowak added a commit that referenced this issue Dec 13, 2022
Part of: #2952

This change validates the installation status of Dapr inside links RP
for Dapr resources. This is step one in removing Dapr from Radius'
default installation. After we have a good experience with Dapr missing,
we can remove it.

This validation is only applied on PUT calls to be more friendly to API
consumers. We still allow clients to get and list dapr link resources
without Dapr installed.

The pattern I followed is similar to the validation we perform for the
AKV CSI driver.
rynowak added a commit that referenced this issue Dec 13, 2022
Fixes: #2952

This change removes Dapr from Radius' installation, and makes it the
user's responsibility. Previously in #4852 we added checks to all of the
Dapr links that will prevent creation of those resources without Dapr
installed. So we're now ready to remove it from our installation code.
rynowak added a commit that referenced this issue Dec 13, 2022
Fixes: #2952

This change removes Dapr from Radius' installation, and makes it the
user's responsibility. Previously in #4852 we added checks to all of the
Dapr links that will prevent creation of those resources without Dapr
installed. So we're now ready to remove it from our installation code.
rynowak added a commit that referenced this issue Dec 13, 2022
Fixes: #2952

This change removes Dapr from Radius' installation, and makes it the
user's responsibility. Previously in #4852 we added checks to all of the
Dapr links that will prevent creation of those resources without Dapr
installed. So we're now ready to remove it from our installation code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dapr Related to Dapr integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants