Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CLI prompting package to bubbletea #3947

Closed
5 tasks done
Tracked by #3500
AaronCrawfis opened this issue Sep 28, 2022 · 0 comments · Fixed by #4671 or #4912
Closed
5 tasks done
Tracked by #3500

Switch CLI prompting package to bubbletea #3947

AaronCrawfis opened this issue Sep 28, 2022 · 0 comments · Fixed by #4671 or #4912

Comments

@AaronCrawfis
Copy link
Contributor

AaronCrawfis commented Sep 28, 2022

Overview of feature request

Switch from promptUI to https://github.com/charmbracelet/bubbletea

Additional context

promptui is unmaintained and has bugs that are not being addressed. We should switch to bubbletea in order to fix open bugs and get updated features.

Tasks

AB#4120

bjoginapally added a commit that referenced this issue Nov 18, 2022
# Description

This change adds list and text prompts functionality for bubble tea.
Changes in the respective commands will be made later.

## Issue reference

Fixes: #3947 

## Checklist

Please make sure you've completed the relevant tasks for this PR, out of
the following list:

* [x] Code compiles correctly
* [ ] Adds necessary unit tests for change
* [ ] Adds necessary E2E tests for change
* [x] Unit tests passing
* [ ] Extended the documentation / Created issue for it

Mac:

<img width="603" alt="Screenshot 2022-11-16 at 12 35 12 PM"
src="https://user-images.githubusercontent.com/99223262/202291102-29bc2d0e-8fa3-493f-aabd-42f1c8cf2890.png">
<img width="305" alt="Screenshot 2022-11-16 at 12 49 00 PM"
src="https://user-images.githubusercontent.com/99223262/202291107-082b95af-5779-4f4b-b5f4-0f9c1b1b81d6.png">

Windows:

<img width="356" alt="Screenshot 2022-11-16 at 3 42 08 PM"
src="https://user-images.githubusercontent.com/99223262/202319083-c1347d1f-274a-47cc-a467-54240adeeaff.png">
<img width="371" alt="Screenshot 2022-11-16 at 3 42 22 PM"
src="https://user-images.githubusercontent.com/99223262/202319084-a6f1b53a-0789-4e21-9c35-e81f4ab736c2.png">
<img width="414" alt="Screenshot 2022-11-16 at 3 42 29 PM"
src="https://user-images.githubusercontent.com/99223262/202319086-27ee13fe-ccb3-41ad-b1e8-933717539482.png">

Co-authored-by: Bharath Joginapally <[email protected]>
@AaronCrawfis AaronCrawfis reopened this Dec 1, 2022
bjoginapally pushed a commit that referenced this issue Jan 3, 2023
- Add bubble tea prompter to cli framework
- Change delete command to use bubbletea framework

issue: #3947
bjoginapally pushed a commit that referenced this issue Jan 3, 2023
- Add bubble tea prompter to cli framework
- Change delete command to use bubbletea framework

issue: #3947
bjoginapally pushed a commit that referenced this issue Jan 5, 2023
- Add bubble tea prompter to cli framework
- Change delete command to use bubbletea framework

issue: #3947
bjoginapally added a commit that referenced this issue Jan 5, 2023
# Description

- Add bubble tea prompter to cli framework
- Change delete commands to use bubbletea framework


PS:  Follow up PR for init changes
## Issue reference

<!--
We strive to have all PR being opened based on an issue, where the
problem or feature have been discussed prior to implementation.
-->

Partially addresses: #3947 

## Checklist

Please make sure you've completed the relevant tasks for this PR, out of
the following list:

* [x] Code compiles correctly
* [ ] Adds necessary unit tests for change
* [ ] Adds necessary E2E tests for change
* [x] Unit tests passing
* [ ] Extended the documentation / Created issue for it

<img width="978" alt="Screenshot 2023-01-05 at 10 30 52 AM"
src="https://user-images.githubusercontent.com/99223262/210854415-54b9a4a0-9478-41a8-aec2-a67ec9cbd6e4.png">
<img width="984" alt="Screenshot 2023-01-05 at 10 31 09 AM"
src="https://user-images.githubusercontent.com/99223262/210854417-cb044d52-2378-44d2-8783-d04065a623b8.png">

Co-authored-by: Bharath Joginapally <[email protected]>
bjoginapally pushed a commit that referenced this issue Jan 6, 2023
bjoginapally added a commit that referenced this issue Jan 6, 2023
# Description

Changes prompts to bubble tea framework from prompt ui

PS: Removal of prompt UI in next PR

## Issue reference

<!--
We strive to have all PR being opened based on an issue, where the
problem or feature have been discussed prior to implementation.
-->

Fixes: #3947 #4796 

## Checklist

Please make sure you've completed the relevant tasks for this PR, out of
the following list:

* [x] Code compiles correctly
* [x] Adds necessary unit tests for change
* [ ] Adds necessary E2E tests for change
* [x] Unit tests passing
* [ ] Extended the documentation / Created issue for it


<img width="826" alt="Screenshot 2023-01-06 at 10 38 06 AM"
src="https://user-images.githubusercontent.com/99223262/211077446-95c612e1-bb91-4280-aacc-bf369b0ed94b.png">
<img width="1072" alt="Screenshot 2023-01-06 at 10 38 13 AM"
src="https://user-images.githubusercontent.com/99223262/211077451-b9721748-35ea-464b-8357-e75dcbeaea2f.png">
<img width="835" alt="Screenshot 2023-01-06 at 10 38 29 AM"
src="https://user-images.githubusercontent.com/99223262/211077454-2f816ae7-ee3a-41ee-8540-df6bdc3fda5e.png">
<img width="998" alt="Screenshot 2023-01-06 at 10 38 50 AM"
src="https://user-images.githubusercontent.com/99223262/211077459-91bb41d5-133d-4a20-991c-9db546cf29ae.png">
<img width="740" alt="Screenshot 2023-01-06 at 10 39 14 AM"
src="https://user-images.githubusercontent.com/99223262/211077463-5d645205-15f6-4132-bc0b-c5eed37176dc.png">
<img width="869" alt="Screenshot 2023-01-06 at 10 39 21 AM"
src="https://user-images.githubusercontent.com/99223262/211077464-09de7a30-b0aa-45a9-b1af-180245790718.png">
<img width="841" alt="Screenshot 2023-01-06 at 10 40 35 AM"
src="https://user-images.githubusercontent.com/99223262/211077468-72d2afa3-c8b6-41aa-ba8b-2b78164b8897.png">

Co-authored-by: Bharath Joginapally <[email protected]>
mishrapratikshya pushed a commit that referenced this issue Feb 2, 2023
# Description

- Add bubble tea prompter to cli framework
- Change delete commands to use bubbletea framework


PS:  Follow up PR for init changes
## Issue reference

<!--
We strive to have all PR being opened based on an issue, where the
problem or feature have been discussed prior to implementation.
-->

Partially addresses: #3947 

## Checklist

Please make sure you've completed the relevant tasks for this PR, out of
the following list:

* [x] Code compiles correctly
* [ ] Adds necessary unit tests for change
* [ ] Adds necessary E2E tests for change
* [x] Unit tests passing
* [ ] Extended the documentation / Created issue for it

<img width="978" alt="Screenshot 2023-01-05 at 10 30 52 AM"
src="https://user-images.githubusercontent.com/99223262/210854415-54b9a4a0-9478-41a8-aec2-a67ec9cbd6e4.png">
<img width="984" alt="Screenshot 2023-01-05 at 10 31 09 AM"
src="https://user-images.githubusercontent.com/99223262/210854417-cb044d52-2378-44d2-8783-d04065a623b8.png">

Co-authored-by: Bharath Joginapally <[email protected]>
mishrapratikshya pushed a commit that referenced this issue Feb 2, 2023
# Description

Changes prompts to bubble tea framework from prompt ui

PS: Removal of prompt UI in next PR

## Issue reference

<!--
We strive to have all PR being opened based on an issue, where the
problem or feature have been discussed prior to implementation.
-->

Fixes: #3947 #4796 

## Checklist

Please make sure you've completed the relevant tasks for this PR, out of
the following list:

* [x] Code compiles correctly
* [x] Adds necessary unit tests for change
* [ ] Adds necessary E2E tests for change
* [x] Unit tests passing
* [ ] Extended the documentation / Created issue for it


<img width="826" alt="Screenshot 2023-01-06 at 10 38 06 AM"
src="https://user-images.githubusercontent.com/99223262/211077446-95c612e1-bb91-4280-aacc-bf369b0ed94b.png">
<img width="1072" alt="Screenshot 2023-01-06 at 10 38 13 AM"
src="https://user-images.githubusercontent.com/99223262/211077451-b9721748-35ea-464b-8357-e75dcbeaea2f.png">
<img width="835" alt="Screenshot 2023-01-06 at 10 38 29 AM"
src="https://user-images.githubusercontent.com/99223262/211077454-2f816ae7-ee3a-41ee-8540-df6bdc3fda5e.png">
<img width="998" alt="Screenshot 2023-01-06 at 10 38 50 AM"
src="https://user-images.githubusercontent.com/99223262/211077459-91bb41d5-133d-4a20-991c-9db546cf29ae.png">
<img width="740" alt="Screenshot 2023-01-06 at 10 39 14 AM"
src="https://user-images.githubusercontent.com/99223262/211077463-5d645205-15f6-4132-bc0b-c5eed37176dc.png">
<img width="869" alt="Screenshot 2023-01-06 at 10 39 21 AM"
src="https://user-images.githubusercontent.com/99223262/211077464-09de7a30-b0aa-45a9-b1af-180245790718.png">
<img width="841" alt="Screenshot 2023-01-06 at 10 40 35 AM"
src="https://user-images.githubusercontent.com/99223262/211077468-72d2afa3-c8b6-41aa-ba8b-2b78164b8897.png">

Co-authored-by: Bharath Joginapally <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants