Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a new render.go file for Kubernetes metadata. For this stage, only support metadata on the container resource. #4353

Closed
Tracked by #4351
Reshrahim opened this issue Oct 26, 2022 · 0 comments · Fixed by #4675
Assignees

Comments

@Reshrahim
Copy link
Contributor

Reshrahim commented Oct 26, 2022

AB#5184

@lakshmimsft lakshmimsft self-assigned this Nov 7, 2022
lakshmimsft added a commit that referenced this issue Nov 28, 2022
# Description

This PR creates renderers for Kubernetes Metadata extension. We will
begin with first making it work for Containers and then update to
cascade values from Env and Application extensions if they exist.

## 4351

Fixes: #4353

## Checklist

Please make sure you've completed the relevant tasks for this PR, out of
the following list:

* [ ] Code compiles correctly
* [ ] Adds necessary unit tests for change
* [ ] Adds necessary E2E tests for change
* [ ] Unit tests passing
* [ ] Extended the documentation / Created issue for it

Co-authored-by: Lakshmi Javadekar <[email protected]>
@lakshmimsft lakshmimsft changed the title Implement a new render.go file for Kubernetes metadata, similar to https://github.com/project-radius/radius/blob/main/pkg/corerp/renderers/daprextension/renderer.go. For this stage, only support metadata on the container resource itself Implement a new render.go file for Kubernetes metadata. For this stage, only support metadata on the container resource. Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants