Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding global scope to Applications.Core/secretstores #7030

Closed
1 task
vishwahiremat opened this issue Jan 16, 2024 · 3 comments · Fixed by #7155
Closed
1 task

Adding global scope to Applications.Core/secretstores #7030

vishwahiremat opened this issue Jan 16, 2024 · 3 comments · Fixed by #7155
Labels
feature This issue describes a feature request in Radius important This item is a high priority Issue we intend to address as soon as possible triaged This issue has been reviewed and triaged

Comments

@vishwahiremat
Copy link
Contributor

vishwahiremat commented Jan 16, 2024 •
edited by azure-boards bot
Loading

Overview of feature request

Today Applications.Core/secretstores is tied to application scope . But to use secret store to store credentials for private repository, we need to have secret store created before application/environment. So we need to remove the required application property and make it available to deploy it global scope or move to UCP resources.

Acceptance criteria

  • We should be able to deploy the secretStore before environment/application is created.
  • Its good to have cli commands to manage the secret store.

Additional context

No response

Would you like to support us?

  • Yes, I would like to support you

AB#10885
@vishwahiremat vishwahiremat added the feature This issue describes a feature request in Radius label Jan 16, 2024
@radius-triage-bot
Copy link

👋 @vishwahiremat Thanks for filing this feature request.

A project maintainer will review this feature request and get back to you soon.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@shalabhms shalabhms changed the title Adding gloabal scope to Applications.Core/secretstores Adding global scope to Applications.Core/secretstores Jan 18, 2024
@shalabhms shalabhms added the triaged This issue has been reviewed and triaged label Jan 18, 2024
@radius-triage-bot
Copy link

👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@shalabhms shalabhms added the important This item is a high priority Issue we intend to address as soon as possible label Jan 18, 2024
@radius-triage-bot
Copy link

We've prioritized work on this issue. Please subscribe to this issue for notifications, we'll provide updates as we make progress.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@vishwahiremat vishwahiremat mentioned this issue Feb 9, 2024
Merged
kachawla added a commit that referenced this issue Feb 23, 2024
@vishwahiremat @kachawla
Adding changes to extend secret stores scope to global (#7155)
6885574 
# Description

- Adding changes to support global scope
- Remove appliction as a requred property
- Create namespace provided by user if not exists
- Adding unit tests

Design doc: radius-project/design-notes#38

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->


- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: #7030

---------

Signed-off-by: Vishwanath Hiremath <[email protected]>
Signed-off-by: Karishma Chawla <[email protected]>
Co-authored-by: Karishma Chawla <[email protected]>
willdavsmith pushed a commit to willdavsmith/radius that referenced this issue Feb 23, 2024
@vishwahiremat @kachawla @willdavsmith
Adding changes to extend secret stores scope to global (radius-projec…
ba89c65 
…t#7155)

# Description

- Adding changes to support global scope
- Remove appliction as a requred property
- Create namespace provided by user if not exists
- Adding unit tests

Design doc: radius-project/design-notes#38

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: radius-project#7030

---------

Signed-off-by: Vishwanath Hiremath <[email protected]>
Signed-off-by: Karishma Chawla <[email protected]>
Co-authored-by: Karishma Chawla <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
willdavsmith pushed a commit to willdavsmith/radius that referenced this issue Mar 4, 2024
@vishwahiremat @kachawla @willdavsmith
Adding changes to extend secret stores scope to global (radius-projec…
07511a6 
…t#7155)

# Description

- Adding changes to support global scope
- Remove appliction as a requred property
- Create namespace provided by user if not exists
- Adding unit tests

Design doc: radius-project/design-notes#38

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->


- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: radius-project#7030

---------

Signed-off-by: Vishwanath Hiremath <[email protected]>
Signed-off-by: Karishma Chawla <[email protected]>
Co-authored-by: Karishma Chawla <[email protected]>
willdavsmith pushed a commit to willdavsmith/radius that referenced this issue Apr 8, 2024
@vishwahiremat @kachawla @willdavsmith
Adding changes to extend secret stores scope to global (radius-projec…
a343906 
…t#7155)

# Description

- Adding changes to support global scope
- Remove appliction as a requred property
- Create namespace provided by user if not exists
- Adding unit tests

Design doc: radius-project/design-notes#38

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: radius-project#7030

---------

Signed-off-by: Vishwanath Hiremath <[email protected]>
Signed-off-by: Karishma Chawla <[email protected]>
Co-authored-by: Karishma Chawla <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature This issue describes a feature request in Radius important This item is a high priority Issue we intend to address as soon as possible triaged This issue has been reviewed and triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding changes to extend secret stores scope to global vishwahiremat/radius
2 participants
@shalabhms @vishwahiremat