Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Github Release step being skipped during release #7113

Closed
1 task
vinayada1 opened this issue Feb 2, 2024 · 1 comment · Fixed by #7127
Closed
1 task

Publish Github Release step being skipped during release #7113

vinayada1 opened this issue Feb 2, 2024 · 1 comment · Fixed by #7127
Labels
bug Something is broken or not working as expected

Comments

@vinayada1
Copy link
Contributor

vinayada1 commented Feb 2, 2024

Steps to reproduce

Run release verification steps and see this error:-
https://github.com/radius-project/radius/actions/runs/7750001938/job/21135535696

The previous step of merging versions.yaml file changes to release branch skipped the "publish github release" step:-
https://github.com/radius-project/radius/actions/runs/7749861163

Observed behavior

No response

Desired behavior

New release should be published and Release verification should not fail

Workaround

No response

rad Version

This is during 0.30.0 release

Operating system

No response

Additional context

No response

Would you like to support us?

  • Yes, I would like to support you

AB#11096

@vinayada1 vinayada1 added the bug Something is broken or not working as expected label Feb 2, 2024
@radius-triage-bot
Copy link

👋 @vinayada1 Thanks for filing this bug report.

A project maintainer will review this report and get back to you soon. If you'd like immediate help troubleshooting, please visit our Discord server.

For more information on our triage process please visit our triage overview

@vinayada1 vinayada1 changed the title Release steps being skipped during release during release verification Publish Github Release step being skipped during release during release verification Feb 2, 2024
@vinayada1 vinayada1 changed the title Publish Github Release step being skipped during release during release verification Publish Github Release step being skipped during release Feb 2, 2024
vinayada1 pushed a commit that referenced this issue Feb 2, 2024
# Description

* Fix release.yaml to run release workflow on push to release branch

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).
- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: #7113

Signed-off-by: willdavsmith <[email protected]>
vinayada1 pushed a commit that referenced this issue Feb 2, 2024
# Description

* Fix release.yaml to run release workflow on push to release branch

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).
- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: #7113

Signed-off-by: willdavsmith <[email protected]>
vinayada1 added a commit that referenced this issue Feb 2, 2024
# Description

Cherry pick workflow fix into release branch:-

* Fix release.yaml to run release workflow on push to release branch

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).
- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: #7113

# Description

_Please explain the changes you've made._

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->


- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: #issue_number

Signed-off-by: willdavsmith <[email protected]>
Co-authored-by: Will Smith <[email protected]>
willdavsmith added a commit to willdavsmith/radius that referenced this issue Mar 4, 2024
# Description

* Fix release.yaml to run release workflow on push to release branch

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).
- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: radius-project#7113

Signed-off-by: willdavsmith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken or not working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant