Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rad deploy should be able to use environments in different groups to deploy application #7520

Closed
nithyatsu opened this issue Apr 18, 2024 · 2 comments · Fixed by #7895
Closed

rad deploy should be able to use environments in different groups to deploy application #7520

nithyatsu opened this issue Apr 18, 2024 · 2 comments · Fixed by #7895
Assignees
@nithyatsu
Labels
triaged This issue has been reviewed and triaged

Comments

@nithyatsu
Copy link
Contributor

nithyatsu commented Apr 18, 2024 •
edited by azure-boards bot
Loading

rad deploy today does not allow this since it searches for environments in current scope only.

nithya@Nithyas-MacBook-Pro bug7052 % rad env list
RESOURCE    TYPE                            GROUP     STATE
a           Applications.Core/environments  default   Succeeded
default     Applications.Core/environments  default   Succeeded
demo        Applications.Core/environments  default   Succeeded
production  Applications.Core/environments  default   Succeeded

nithya@Nithyas-MacBook-Pro bug7052 % rad group switch b

nithya@Nithyas-MacBook-Pro bug7052 % rad env list
RESOURCE  TYPE      GROUP     STATE
nithya@Nithyas-MacBook-Pro bug7052 % rad deploy ctnr.bicep --parameters magpieimage=ghcr.io/radius-project/magpiego:latest --group b --environment production
The environment "production" does not exist in scope "/planes/radius/local/resourceGroups/b". Run `rad env create` first.

AB#11797
@sylvainsf sylvainsf added the triaged This issue has been reviewed and triaged label Apr 22, 2024
@radius-triage-bot
Copy link

👍 We've reviewed this issue and have agreed to add it to our backlog. Please subscribe to this issue for notifications, we'll provide updates when we pick it up.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

rynowak added a commit to rynowak/radius that referenced this issue May 14, 2024
@rynowak
Update CLI client code and add tests
7d2a307 
This change is a major update to the CLI's client code for interacting with the Radius API.

The client grew organically over time as we added features. Since it's client code it wasn't
well tested because testing it would require a lot of mocking. Unfortunately in some places
we *do* have complex logic in this code and unfortunately we also have some bugs.

I'm working on another fix to address radius-project#7520, and encountered a lot of limitations with the client
code so I decided to fix it.

This change addresses the following:

- Reviewed the API and made updates for consistency.
- Added tests for ALL of the functions on the client.
- Updated each API to accept either a resource ID or a resource name (needed for radius-project#7520).

This update does the
@rynowak rynowak mentioned this issue May 14, 2024
Merged
rynowak added a commit to rynowak/radius that referenced this issue May 14, 2024
@rynowak
Update CLI client code and add tests
5c98df9 
This change is a major update to the CLI's client code for interacting with the Radius API.

The client grew organically over time as we added features. Since it's client code it wasn't
well tested because testing it would require a lot of mocking. Unfortunately in some places
we *do* have complex logic in this code and unfortunately we also have some bugs.

I'm working on another fix to address radius-project#7520, and encountered a lot of limitations with the client
code so I decided to fix it.

This change addresses the following:

- Reviewed the API and made updates for consistency.
- Added tests for ALL of the functions on the client.
- Updated each API to accept either a resource ID or a resource name (needed for radius-project#7520).

This update does the

Signed-off-by: Ryan Nowak <[email protected]>
@nithyatsu nithyatsu self-assigned this May 14, 2024
rynowak added a commit to rynowak/radius that referenced this issue May 14, 2024
@rynowak
Update CLI client code and add tests
90bf38a 
This change is a major update to the CLI's client code for interacting with the Radius API.

The client grew organically over time as we added features. Since it's client code it wasn't
well tested because testing it would require a lot of mocking. Unfortunately in some places
we *do* have complex logic in this code and unfortunately we also have some bugs.

I'm working on another fix to address radius-project#7520, and encountered a lot of limitations with the client
code so I decided to fix it.

This change addresses the following:

- Reviewed the API and made updates for consistency.
- Added tests for ALL of the functions on the client.
- Updated each API to accept either a resource ID or a resource name (needed for radius-project#7520).

This update does the

Signed-off-by: Ryan Nowak <[email protected]>
rynowak added a commit to rynowak/radius that referenced this issue May 14, 2024
@rynowak
Update CLI client code and add tests
0c49ad0 
This change is a major update to the CLI's client code for interacting with the Radius API.

The client grew organically over time as we added features. Since it's client code it wasn't
well tested because testing it would require a lot of mocking. Unfortunately in some places
we *do* have complex logic in this code and unfortunately we also have some bugs.

I'm working on another fix to address radius-project#7520, and encountered a lot of limitations with the client
code so I decided to fix it.

This change addresses the following:

- Reviewed the API and made updates for consistency.
- Added tests for ALL of the functions on the client.
- Updated each API to accept either a resource ID or a resource name (needed for radius-project#7520).

This update does the

Signed-off-by: Ryan Nowak <[email protected]>
rynowak added a commit to rynowak/radius that referenced this issue May 15, 2024
@rynowak
Update CLI client code and add tests
f657d97 
This change is a major update to the CLI's client code for interacting with the Radius API.

The client grew organically over time as we added features. Since it's client code it wasn't
well tested because testing it would require a lot of mocking. Unfortunately in some places
we *do* have complex logic in this code and unfortunately we also have some bugs.

I'm working on another fix to address radius-project#7520, and encountered a lot of limitations with the client
code so I decided to fix it.

This change addresses the following:

- Reviewed the API and made updates for consistency.
- Added tests for ALL of the functions on the client.
- Updated each API to accept either a resource ID or a resource name (needed for radius-project#7520).

This update does the

Signed-off-by: Ryan Nowak <[email protected]>
rynowak added a commit to rynowak/radius that referenced this issue May 15, 2024
@rynowak
Update CLI client code and add tests
5211238 
This change is a major update to the CLI's client code for interacting with the Radius API.

The client grew organically over time as we added features. Since it's client code it wasn't
well tested because testing it would require a lot of mocking. Unfortunately in some places
we *do* have complex logic in this code and unfortunately we also have some bugs.

I'm working on another fix to address radius-project#7520, and encountered a lot of limitations with the client
code so I decided to fix it.

This change addresses the following:

- Reviewed the API and made updates for consistency.
- Added tests for ALL of the functions on the client.
- Updated each API to accept either a resource ID or a resource name (needed for radius-project#7520).

This update does the

Signed-off-by: Ryan Nowak <[email protected]>
rynowak added a commit that referenced this issue May 16, 2024
@rynowak
Update CLI client code and add tests (#7594)
427eed2 
# Description

This change is a major update to the CLI's client code for interacting
with the Radius API.

The client grew organically over time as we added features. Since it's
client code it wasn't well tested because testing it would require a lot
of mocking. Unfortunately in some places we *do* have complex logic in
this code and unfortunately we also have some bugs.

I'm working on another fix to address #7520, and encountered a lot of
limitations with the client code so I decided to fix it.

This change addresses the following:

- Reviewed the API and made updates for consistency.
- Added tests for ALL of the functions on the client.
- Updated each API to accept either a resource ID or a resource name
(needed for #7520).

## Type of change

- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

Signed-off-by: Ryan Nowak <[email protected]>
@willtsai willtsai added the important This item is a high priority Issue we intend to address as soon as possible label Jun 18, 2024
@radius-triage-bot
Copy link

We've prioritized work on this issue. Please subscribe to this issue for notifications, we'll provide updates as we make progress.

We also welcome community contributions! If you would like to pick this item up sooner and submit a pull request, please visit our contribution guidelines and assign this to yourself by commenting "/assign" on this issue.

For more information on our triage process please visit our triage overview

@willtsai willtsai removed the important This item is a high priority Issue we intend to address as soon as possible label Aug 28, 2024
@nithyatsu nithyatsu mentioned this issue Sep 7, 2024
Merged
nithyatsu added a commit that referenced this issue Sep 10, 2024
@nithyatsu
support deployment of an application to a scope "scope1" using enviro…
897f2aa 
…nment in a different scope "scope2" (#7895)

# Description

Today, rad deploy can use only the environments that are in same scope
as where the application is being deployed to (either default scope or
one specified by -g).
It should be able to use environments in different groups to deploy
application.

## Type of change

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).
Fixes: #7520

---------

Signed-off-by: nithyatsu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nithyatsu nithyatsu

Labels
triaged This issue has been reviewed and triaged
Projects
None yet
Milestone
No milestone
3 participants
@sylvainsf @willtsai @nithyatsu