Fix UCP examples to conform with oav validate-example command
#4532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asilverman
commented
Nov 8, 2022
...tion/ucp/resource-manager/UCP/preview/2022-09-01-privatepreview/examples/CredentialsPut.json
Outdated
Show resolved
Hide resolved
asilverman
commented
Nov 9, 2022
asilverman
commented
Nov 9, 2022
swagger/specification/ucp/resource-manager/UCP/preview/examples/ResourceGroupsList.json
Show resolved
Hide resolved
asilverman
commented
Nov 9, 2022
swagger/specification/ucp/resource-manager/UCP/preview/2022-09-01-privatepreview/ucp.json
Show resolved
Hide resolved
asilverman
commented
Nov 9, 2022
swagger/specification/ucp/resource-manager/UCP/preview/2022-09-01-privatepreview/ucp.json
Show resolved
Hide resolved
asilverman
commented
Nov 9, 2022
vinayada1
reviewed
Nov 9, 2022
asilverman
force-pushed
the
asilverman/spec-validation
branch
from
135cfde to
73a4863
Compare
asilverman
force-pushed
the
asilverman/spec-validation
branch
from
5b72e6e to
b2e97bb
Compare
asilverman
commented
Nov 9, 2022
asilverman
changed the title
oav validate-example command oav validate-example command
ytimocin
reviewed
Nov 9, 2022
...er/Applications.Core/preview/2022-03-15-privatepreview/examples/ApplicationsListByScope.json
Outdated
Show resolved
Hide resolved
vinayada1
approved these changes
Nov 14, 2022
rynowak
reviewed
Nov 14, 2022
...n/ucp/resource-manager/UCP/preview/2022-09-01-privatepreview/examples/AWSCredentialsGet.json
Show resolved
Hide resolved
...n/ucp/resource-manager/UCP/preview/2022-09-01-privatepreview/examples/AWSCredentialsPut.json
Show resolved
Hide resolved
...ucp/resource-manager/UCP/preview/2022-09-01-privatepreview/examples/AzureCredentialsGet.json
Show resolved
Hide resolved
nithyatsu
approved these changes
Nov 14, 2022
|
Is there some instruction to run the oav locally? |
|
@asilverman thanks for this work. I have the suggestion. We have not run the linter for all swagger files for a while. We can add oav linter CI check first but set it as optional check, so it should not block PR merge. Then we can fix the discovered linter errors iteratively. WDYT? |
Yes - |
added 9 commits
November 15, 2022 11:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The examples we specify in our OpenAPI spec (
x-ms-examples) should be verified to conform to the spec. This PR adds a check for the UCP OpenAPI spec in the CI/CD pipeline to ensure that moving forward we update any drifts from the spec as the spec evolves.Fixes #4566
Changes
ucp.jsonspec to remove async operations (per conversation with @Vinaya)api-versionparam to Credentials