Clean up resources even though AWS resources are not used #4612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotalik
reviewed
Nov 10, 2022
jkotalik
reviewed
Nov 10, 2022
youngbupark
commented
Nov 10, 2022
| @@ -207,12 +207,18 @@ func (ct CoreRPTest) Test(t *testing.T) { | |||
| } | |||
| }) | |||
|
|
|||
| t.Logf("Creating secrets if provided") | |||
There was a problem hiding this comment.
lol.. this code had been deleted for some reason...
5 tasks
youngbupark
changed the title
youngbupark
changed the title
youngbupark
changed the title
youngbupark
commented
Nov 11, 2022
vinayada1
reviewed
Nov 11, 2022
| t.Logf("validating deletion of AWS resource for %s", ct.Description) | ||
| validation.ValidateNoAWSResource(ctx, t, &resource, ct.Options.AWSClient) | ||
| t.Logf("finished validation of deletion of AWS resource %s for %s", resource.Name, ct.Description) | ||
| } | ||
| } | ||
|
|
||
| if (step.CoreRPResources == nil && step.SkipKubernetesOutputResourceValidation) || step.SkipResourceDeletion { |
There was a problem hiding this comment.
Could we remove the continue here and change the logic in this line so that we do not add similar regressions if some cleanup gets added after this?
There was a problem hiding this comment.
Ah this condition is true only if CoreRPResource is empty and skipped explicitly. So generally, continue will not be executed.
kachawla
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The root cause is the bug in DELETE controller of Dapr resource. As a workaround, this PR skips the resource deletion during tearing down the test.
Changing test concurrency to 1 since local tests without concurrent tests are passing.Issue reference
Fixes: #4543
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: