Init ucp secret at server start #4674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngbupark
reviewed
Nov 17, 2022
| @@ -24,6 +24,11 @@ storageProvider: | |||
| etcd: | |||
| inmemory: true | |||
|
|
|||
| secretProvider: | |||
There was a problem hiding this comment.
Please add kuberentes secret for helm chart.
https://github.com/project-radius/radius/blob/main/deploy/Chart/charts/ucp/ucp-config.yaml
And then ensure that ucp service account has secret resource permission.
There was a problem hiding this comment.
Thanks for catching this. I have added the config I missed. For the permissions, I added secrets permissions to ucp.dev only, as those will be serving ucp secret
ytimocin
reviewed
Nov 17, 2022
ytimocin
approved these changes
Nov 18, 2022
rynowak
reviewed
Nov 18, 2022
| @@ -40,6 +40,7 @@ rules: | |||
| - ucp.dev | |||
| resources: | |||
| - resources | |||
| - secrets | |||
There was a problem hiding this comment.
This isn't right. Kubernetes secrets are part of the "core" group. We should already have permission to access secrets.
There was a problem hiding this comment.
oh thanks clarifying. I will change this back
…sions already exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change initializes ucp secret client on startup
Issue reference
Fixes: #3595
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: