Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test for AWS multi-identifier resource #4685

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Add e2e test for AWS multi-identifier resource #4685

merged 1 commit into from
Nov 21, 2022

Conversation

vinayada1
Copy link
Contributor

@vinayada1 vinayada1 commented Nov 18, 2022 •
edited
Loading

Description

Add e2e test for multi identifier resource

#4596

Fixes: #4596

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Adds necessary unit tests for change
  • Adds necessary E2E tests for change
  • Unit tests passing
  • Extended the documentation / Created issue for it

@vinayada1 vinayada1 requested a review from a team as a code owner November 18, 2022 22:58
jkotalik
jkotalik reviewed Nov 21, 2022
View reviewed changes
test/functional/corerp/resources/aws_multi_identifier_resource_test.go
)

func Test_AWS_MultiIdentifier_Resource(t *testing.T) {
template := "testdata/aws-multi-identifier.bicep"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked?

😍

@vinayada1 vinayada1 merged commit 4745742 into radius-project:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkotalik jkotalik jkotalik approved these changes

@ytimocin ytimocin ytimocin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@vinayada1 @ytimocin @jkotalik