Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding in a functional test for using dev recipes #4804

Merged
merged 9 commits into from
Dec 3, 2022
Merged

Adding in a functional test for using dev recipes #4804

merged 9 commits into from
Dec 3, 2022

Conversation

snehabandla
Copy link
Contributor

@snehabandla snehabandla commented Dec 2, 2022 •
edited
Loading

Description

Adding in a functional test that uses a dev recipe that is linked to the environment when it is created with useDevRecipes=true

Issue reference

Fixes: #4162 AB#4359

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Adds necessary unit tests for change
  • Adds necessary E2E tests for change
  • Unit tests passing
  • Extended the documentation / Created issue for it

@snehabandla snehabandla changed the title Test commit since local run isn't working Adding in a functional test for using dev recipes Dec 2, 2022
@snehabandla snehabandla marked this pull request as ready for review December 2, 2022 21:03
@snehabandla snehabandla requested a review from a team as a code owner December 2, 2022 21:03
vishwahiremat
vishwahiremat approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@vishwahiremat vishwahiremat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@snehabandla snehabandla merged commit e571694 into main Dec 3, 2022
@snehabandla snehabandla deleted the snehab/devrecipestest branch December 3, 2022 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishwahiremat vishwahiremat vishwahiremat approved these changes

@kachawla kachawla kachawla approved these changes

@shalabhms shalabhms shalabhms approved these changes

Assignees

@shalabhms shalabhms

@kachawla kachawla

@vishwahiremat vishwahiremat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add functional test to validate that a user can use a radius owned recipe
5 participants
@snehabandla @shalabhms @kachawla @vishwahiremat @mishrapratikshya