Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release-process.md #4840

Merged
merged 3 commits into from
Dec 15, 2022
Merged

Update release-process.md #4840

merged 3 commits into from
Dec 15, 2022

Conversation

jkotalik
Copy link
Contributor

@jkotalik jkotalik commented Dec 8, 2022

TODO:

  • Making flow a bit more seamless
  • Asking @willdavsmith the issues he hit with wrong versions from rad version
  • Clarity on doc release process and making it consistent
  • Ensuring this flow works with @lakshmimsft driving the release tomorrow

@jkotalik jkotalik marked this pull request as ready for review December 13, 2022 22:09
@jkotalik jkotalik requested a review from a team as a code owner December 13, 2022 22:09
@shalabhms
Copy link
Contributor

Thanks @jkotalik for updating it !.

sylvainsf
sylvainsf approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@sylvainsf sylvainsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

rynowak
rynowak reviewed Dec 14, 2022
View reviewed changes
docs/contributing/contributing-code/release-process.md
@@ -227,7 +236,7 @@ Let's say we have a bug in a release which needs to be patched for an already cr
git checkout release/0.<VERSION>
git checkout -b <USERNAME>/<BRANCHNAME>
```
3. Cherry-pick the commit that is on `main` onto the branch.
3. Cherry-pick the commit that is on `main` onto the branch. PLEASE USE `-x` HERE TO ENSURE VERSION HISTORY IS PRESERVED.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like how mature and specific these directions have become. Especially how we include a verification as part of each step 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't tell if this is sarcastic or not 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sarcastic. Rotating the responsibility through the team has really improved our docs for this.

@jkotalik jkotalik closed this Dec 15, 2022
@jkotalik jkotalik reopened this Dec 15, 2022
@jkotalik jkotalik merged commit 9f3e307 into main Dec 15, 2022
@jkotalik jkotalik deleted the jkotalik/updateReleaseDocumentation branch December 15, 2022 22:24
mishrapratikshya pushed a commit that referenced this pull request Feb 2, 2023
@jkotalik @mishrapratikshya
Update release-process.md (#4840)
50d0b1b 
- Making flow a bit more seamless
- Asking @willdavsmith the issues he hit with wrong versions from rad
version
- Clarity on doc release process and making it consistent
- Ensuring this flow works with @lakshmimsft driving the release
tomorrow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rynowak rynowak rynowak left review comments

@shalabhms shalabhms shalabhms approved these changes

@sylvainsf sylvainsf sylvainsf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkotalik @shalabhms @sylvainsf @rynowak