Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functional tests for credential operations #4884

Merged
merged 4 commits into from
Dec 31, 2022

Conversation

bjoginapally
Copy link
Contributor

@bjoginapally bjoginapally commented Dec 29, 2022

Description

Adds functional tests for credential operations

Issue reference

Fixes: NA

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Adds necessary unit tests for change
  • Adds necessary E2E tests for change
  • Unit tests passing
  • Extended the documentation / Created issue for it

@bjoginapally bjoginapally requested a review from a team as a code owner December 29, 2022 02:35
test/functional/ucp/credential_test.go Outdated Show resolved Hide resolved
test/functional/ucp/credential_test.go Outdated Show resolved Hide resolved
test/functional/ucp/credential_test.go Outdated Show resolved Hide resolved
test/functional/ucp/credential_test.go Outdated Show resolved Hide resolved
test/functional/ucp/credential_test.go Outdated Show resolved Hide resolved
test/functional/ucp/credential_test.go Outdated Show resolved Hide resolved
test/functional/ucp/credential_test.go Outdated Show resolved Hide resolved
test/functional/ucp/credential_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ytimocin ytimocin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bjoginapally bjoginapally merged commit 6e901ff into main Dec 31, 2022
@bjoginapally bjoginapally deleted the bjoginapally/credential_tests branch December 31, 2022 00:07
mishrapratikshya pushed a commit that referenced this pull request Feb 2, 2023
# Description

Adds functional tests for credential operations

## Issue reference

<!--
We strive to have all PR being opened based on an issue, where the
problem or feature have been discussed prior to implementation.
-->

Fixes: NA

## Checklist

Please make sure you've completed the relevant tasks for this PR, out of
the following list:

* [x] Code compiles correctly
* [ ] Adds necessary unit tests for change
* [x] Adds necessary E2E tests for change
* [x] Unit tests passing
* [ ] Extended the documentation / Created issue for it

Co-authored-by: Bharath Joginapally <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants