Fix flaky recipe parameter test by removing constant resource name #4995
Conversation
| documentdbName: 'account-developer-parameters' | ||
| mongodbName: 'mongodb-developer-parameters' | ||
| documentdbName: 'acnt-developer-${rg}' | ||
| mongodbName: 'mdb-developer-${rg}' |
There was a problem hiding this comment.
renamed it as the length of the account should be less than 3 characters or more than 44 characters long.
| documentdbName: 'account-developer-parameters' | ||
| mongodbName: 'mongodb-developer-parameters' | ||
| documentdbName: 'acnt-developer-${rg}' | ||
| mongodbName: 'mdb-developer-${rg}' |
There was a problem hiding this comment.
Why do we need to use env variable instead of resourceGroup() function?
There was a problem hiding this comment.
it using the resourceGroup() function. Just created a param rg for it in the bicep.
https://github.com/project-radius/radius/blob/147d858ba2dbe8d045b0c5438e6c2500da72608c/test/functional/corerp/resources/testdata/corerp-resources-mongodb-recipe-parameters.bicep#L3
| // skip the test if INTEGRATION_TEST_RESOURCE_GROUP_NAME is not set | ||
| // for running locally set the INTEGRATION_TEST_RESOURCE_GROUP_NAME with the test resourceGroup | ||
| if rg == "" { | ||
| t.Skip("This test needs the env variable INTEGRATION_TEST_RESOURCE_GROUP_NAME to be set") | ||
| } |
There was a problem hiding this comment.
Is there a reason we need to add this check? How would we know if the test is just silently being skipped?
There was a problem hiding this comment.
Added this check for local testing. If some one runs the test without setting INTEGRATION_TEST_RESOURCE_GROUP_NAME then it will skip.
| Identity: "acnt-developer-" + rg, | ||
| }, | ||
| { | ||
| Provider: resourcemodel.ProviderAzure, | ||
| LocalID: outputresource.LocalIDAzureCosmosDBMongo, | ||
| Identity: "mongodb-developer-parameters", | ||
| Identity: "mdb-developer-" + rg, |
There was a problem hiding this comment.
Why are these name validations needed for this particular test? Is there anything special being done on the server side for this scenario that we are trying to validate?
There was a problem hiding this comment.
The mongo resources in the recipe are getting deployed with these names. This is what the developer sets while creating mongo link.
…4995) # Description Fix flaky recipe parameter test by removing constant resource name Added resourceGroup name to the account and mongodb name. ## Issue reference <!-- We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation. --> Fixes: #4992 ## Checklist Please make sure you've completed the relevant tasks for this PR, out of the following list: * [x] Code compiles correctly * [ ] Adds necessary unit tests for change * [ ] Adds necessary E2E tests for change * [x] Unit tests passing * [ ] Extended the documentation / Created issue for it
| @@ -77,8 +77,8 @@ resource recipedb 'Applications.Link/mongoDatabases@2022-03-15-privatepreview' = | |||
| recipe: { | |||
| name: 'mongodb' | |||
| parameters: { | |||
| documentdbName: 'account-developer-parameters' | |||
| mongodbName: 'mongodb-developer-parameters' | |||
| documentdbName: 'acnt-developer-${rg}' | |||
There was a problem hiding this comment.
Can we use a dynamically generated name for account to avoid name collisions in tests? You can either validate by matching prefix or remove account name from parameters and rely just on the database name.
…4995) # Description Fix flaky recipe parameter test by removing constant resource name Added resourceGroup name to the account and mongodb name. ## Issue reference <!-- We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation. --> Fixes: #4992 ## Checklist Please make sure you've completed the relevant tasks for this PR, out of the following list: * [x] Code compiles correctly * [ ] Adds necessary unit tests for change * [ ] Adds necessary E2E tests for change * [x] Unit tests passing * [ ] Extended the documentation / Created issue for it
Description
Fix flaky recipe parameter test by removing constant resource name
Added resourceGroup name to the account and mongodb name.
Issue reference
Fixes: radius-project/core-team#1083
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: