Updating the api versions for clients #5018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytimocin
commented
Jan 24, 2023
Comment on lines
-24
to
25
| dm "github.com/project-radius/radius/pkg/linkrp/datamodel" | ||
| linkrp_dm "github.com/project-radius/radius/pkg/linkrp/datamodel" |
Comment on lines
-36
to
+35
| Value: to.String(&properties.AppId), | ||
| Value: properties.AppId, |
There was a problem hiding this comment.
Is there a reason why we got the address of the AppId and then got the value of the address?
There was a problem hiding this comment.
Probably just for fun. This was probably a copy-paste issue
Comment on lines
+16
to
+23
| // https://github.com/Azure/azure-rest-api-specs/blob/main/specification/sql/resource-manager/readme.md | ||
| SQLManagementClientAPIVersion = "2021-11-01" | ||
|
|
||
| // https://github.com/Azure/azure-rest-api-specs/blob/main/specification/redis/resource-manager/readme.md | ||
| RedisManagementClientAPIVersion = "2022-06-01" | ||
|
|
||
| // https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cosmos-db/resource-manager/readme.md | ||
| DocumentDBManagementClientAPIVersion = "2022-08-15" |
There was a problem hiding this comment.
I got the most recent stable API versions of these clients to hard-code them per the discussion here: #4864 (comment). Do you think this looks right @rynowak?
youngbupark
approved these changes
Jan 25, 2023
rynowak
approved these changes
Jan 25, 2023
mishrapratikshya
pushed a commit
that referenced
this pull request
Jan 26, 2023
# Description Updating the api versions for the clients. ## Issue reference Fixes: #issue_number ## Checklist Please make sure you've completed the relevant tasks for this PR, out of the following list: * [x] Code compiles correctly * [ ] Adds necessary unit tests for change * [ ] Adds necessary E2E tests for change * [x] Unit tests passing * [x] Extended the documentation / Created issue for it
mishrapratikshya
pushed a commit
that referenced
this pull request
Feb 2, 2023
# Description Updating the api versions for the clients. ## Issue reference Fixes: #issue_number ## Checklist Please make sure you've completed the relevant tasks for this PR, out of the following list: * [x] Code compiles correctly * [ ] Adds necessary unit tests for change * [ ] Adds necessary E2E tests for change * [x] Unit tests passing * [x] Extended the documentation / Created issue for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the api versions for the clients.
Issue reference
Fixes: #issue_number
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: