Big Fixes for v0.17-rc1 #5127
Merged
Big Fixes for v0.17-rc1 #5127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Description - Fixes updation of workspace while rad init. - Corrects credential name for default and get operations of cli cred client. - Add support for aws in rad credential show - Remove scope from rad credential azure command ## Issue reference Fixes: #5111 #5119 #5120 ## Checklist Please make sure you've completed the relevant tasks for this PR, out of the following list: * [x] Code compiles correctly * [x] Adds necessary unit tests for change * [ ] Adds necessary E2E tests for change * [x] Unit tests passing * [ ] Extended the documentation / Created issue for it --------- Co-authored-by: Bharath Joginapally <[email protected]>
nithyatsu
approved these changes
Feb 7, 2023
vishwahiremat
added a commit
that referenced
this pull request
Feb 7, 2023
This reverts commit 8499a94.
vishwahiremat
added a commit
that referenced
this pull request
Feb 7, 2023
This reverts commit 8499a94. # Description Merged release/v0.17 into main by mistake, reverting it back. ## Issue reference <!-- We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation. --> Fixes: #issue_number ## Checklist Please make sure you've completed the relevant tasks for this PR, out of the following list: * [ ] Code compiles correctly * [ ] Adds necessary unit tests for change * [ ] Adds necessary E2E tests for change * [ ] Unit tests passing * [ ] Extended the documentation / Created issue for it
mishrapratikshya
pushed a commit
that referenced
this pull request
Feb 14, 2023
# Description Cherry Picked from commits: Fix init and credential bugs 1b14a17 Update dapr recipe renderer to include all output resources fe85dcc ## Issue reference <!-- We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation. --> Fixes: #issue_number ## Checklist Please make sure you've completed the relevant tasks for this PR, out of the following list: * [x] Code compiles correctly * [x] Adds necessary unit tests for change * [x] Adds necessary E2E tests for change * [x] Unit tests passing * [ ] Extended the documentation / Created issue for it --------- Co-authored-by: Bharath <[email protected]> Co-authored-by: Bharath Joginapally <[email protected]> Co-authored-by: karishma-chawla <[email protected]>
mishrapratikshya
pushed a commit
that referenced
this pull request
Feb 14, 2023
This reverts commit 8499a94. # Description Merged release/v0.17 into main by mistake, reverting it back. ## Issue reference <!-- We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation. --> Fixes: #issue_number ## Checklist Please make sure you've completed the relevant tasks for this PR, out of the following list: * [ ] Code compiles correctly * [ ] Adds necessary unit tests for change * [ ] Adds necessary E2E tests for change * [ ] Unit tests passing * [ ] Extended the documentation / Created issue for it
mishrapratikshya
pushed a commit
that referenced
this pull request
Feb 14, 2023
# Description Cherry Picked from commits: Fix init and credential bugs 1b14a17 Update dapr recipe renderer to include all output resources fe85dcc ## Issue reference <!-- We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation. --> Fixes: #issue_number ## Checklist Please make sure you've completed the relevant tasks for this PR, out of the following list: * [x] Code compiles correctly * [x] Adds necessary unit tests for change * [x] Adds necessary E2E tests for change * [x] Unit tests passing * [ ] Extended the documentation / Created issue for it --------- Co-authored-by: Bharath <[email protected]> Co-authored-by: Bharath Joginapally <[email protected]> Co-authored-by: karishma-chawla <[email protected]>
mishrapratikshya
pushed a commit
that referenced
this pull request
Feb 14, 2023
This reverts commit 8499a94. # Description Merged release/v0.17 into main by mistake, reverting it back. ## Issue reference <!-- We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation. --> Fixes: #issue_number ## Checklist Please make sure you've completed the relevant tasks for this PR, out of the following list: * [ ] Code compiles correctly * [ ] Adds necessary unit tests for change * [ ] Adds necessary E2E tests for change * [ ] Unit tests passing * [ ] Extended the documentation / Created issue for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry Picked from commits:
Fix init and credential bugs
1b14a17
Update dapr recipe renderer to include all output resources
fe85dcc
Issue reference
Fixes: #issue_number
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: