Replace AWS.Kinesis/Stream with AWS.S3/Bucket in functional tests #5227
Conversation
willdavsmith
changed the title
Unit-test coverage resultThe unit-test coverage rate is 60.3%. If you want to see the detailed report, please go to
|
| @@ -17,42 +17,50 @@ import ( | |||
|
|
|||
| func Test_AWSRedeployWithUpdatedResourceUpdatesResource(t *testing.T) { | |||
| templateFmt := "testdata/aws-mechanics-redeploy-withupdatedresource.step%d.bicep" | |||
| name := "ms" + uuid.New().String() | |||
| name := "radiusfunctionaltestbucket-" + uuid.New().String() | |||
There was a problem hiding this comment.
Could this run into length constraints?
There was a problem hiding this comment.
this will be 63 characters (e.g. radiusfunctionaltestbucket-4c4f3c7e-8341-41f3-a275-e4b39bbcc449), which conforms to our spec as well as AWS', so we should be good
| test.Test(t) | ||
| } | ||
|
|
||
| func Test_AWS_S3Bucket_Existing(t *testing.T) { |
There was a problem hiding this comment.
Can we add doc here to identify the difference between this test and the one above?
There was a problem hiding this comment.
Could you point me to the doc?
There was a problem hiding this comment.
There was a problem hiding this comment.
basically the idea is that the first step deploys the S3Bucket resource, then the second step uses the bicep existing keyword during the deployment, which should retrieve the same resource. If you check the bicep definition here, you can see that the key and the value are not specified. We add them in the test to make sure we get the same resource. Sorry for the confusion :)
| Tags: [ | ||
| { | ||
| Key: 'testKey' | ||
| Value: 'testValue2' |
There was a problem hiding this comment.
Where is this value tested?
There was a problem hiding this comment.
Unit-test coverage resultThe unit-test coverage rate is 60.3%. If you want to see the detailed report, please go to
|
There was a problem hiding this comment.
@willdavsmith I would change the title of this PR. e.g. Replace AWS.Kinesis/Stream with S3 in functional tests or Use S3 xxx
willdavsmith
changed the title
Description
Issue Reference
https://dev.azure.com/azure-octo/Incubations/_workitems/edit/6401