Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup #5312

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Code cleanup #5312

merged 2 commits into from
Mar 24, 2023

Conversation

vinayada1
Copy link
Contributor

Description

Most code inside ucp/frontend/controller.go is not needed and is replaced by armrpc/frontend/controller.go. Removing unwanted code

#5175

Fixes: #5175

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Adds necessary unit tests for change
  • Adds necessary E2E tests for change
  • Unit tests passing
  • Extended the documentation / Created issue for it

@vinayada1 vinayada1 requested a review from a team as a code owner March 20, 2023 22:28
youngbupark
youngbupark approved these changes Mar 23, 2023
View reviewed changes
Copy link

@youngbupark youngbupark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase from main :). Good to see we remove basecontroller. I think I can remove basecontroller in armrpc package :)

@vinayada1 vinayada1 merged commit 24608f4 into radius-project:main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rynowak rynowak rynowak left review comments

@youngbupark youngbupark youngbupark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UCP should use operation controller instead of frontend controller
3 participants
@vinayada1 @rynowak @youngbupark