Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close streams properly to avoid leaks #5429

Merged
merged 1 commit into from
Apr 10, 2023
Merged

close streams properly to avoid leaks #5429

merged 1 commit into from
Apr 10, 2023

Conversation

vinayada1
Copy link
Contributor

Description

Close opened buffers. Potential memory leak cause

#5237

Fixes: #issue_number

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Adds necessary unit tests for change
  • Adds necessary E2E tests for change
  • Unit tests passing
  • Extended the documentation / Created issue for it

@vinayada1 vinayada1 requested a review from a team as a code owner April 10, 2023 18:20
@vinayada1 vinayada1 changed the title close buffers close streams properly to avoid leaks Apr 10, 2023
@vinayada1 vinayada1 merged commit 0fb38d4 into radius-project:main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willdavsmith willdavsmith willdavsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinayada1 @willdavsmith