Provide RuntimeConfiguration to processor #5505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the RuntimeConfiguration to the set of data provided to a processor. This was a gap we identified while working on Dapr state store support. Since the Dapr state store processor needs to create Kubernetes resources, it needs to know the runtime configuration to get the correct namespace. This change adds the infrastructure needed to get this data, and updates the unit tests of the controller + existing redis processor. The Dapr state store processor will land in a follow up PR, as several changes need to go in first.
rynowak
commented
May 1, 2023
| RuntimeConfiguration recipes.RuntimeConfiguration | ||
|
|
||
| // RecipeOutput represents the output of executing a recipe (may be nil). | ||
| RecipeOutput *recipes.RecipeOutput |
There was a problem hiding this comment.
Defining an options type so we don't have to keep making breaking changes to this API as we add more capabilities.
Test Results2 459 tests +1 2 452 ✔️ +1 1m 59s ⏱️ +3s Results for commit ee0c07b. ± Comparison against base commit 42a281c. This pull request removes 2 and adds 3 tests. Note that renamed tests count towards both. |
|
For the detailed report, please go to
|
kachawla
approved these changes
May 1, 2023
rynowak
commented
May 1, 2023
| eng.EXPECT(). | ||
| Execute(gomock.Any(), recipeMetadata). | ||
| Return(&recipes.RecipeOutput{}, nil). | ||
| Times(1) | ||
| } | ||
|
|
||
| if tt.getErr == nil && !tt.conversionFailure && tt.recipeErr == nil && tt.processorErr == nil && tt.resourceClientErr != nil { | ||
| if stillPassing && tt.runtimeConfigurationErr != nil { |
There was a problem hiding this comment.
I wanted to simplify all of these checks, it was getting kinda ridiculous.
ytimocin
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds the RuntimeConfiguration to the set of data provided to a processor. This was a gap we identified while working on Dapr state store support. Since the Dapr state store processor needs to create Kubernetes resources, it needs to know the runtime configuration to get the correct namespace.
This change adds the infrastructure needed to get this data, and updates the unit tests of the controller + existing redis processor. The Dapr state store processor will land in a follow up PR, as several changes need to go in first.