Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit of functional tests for SecretStores #5510

Merged
merged 16 commits into from
May 4, 2023
Merged

Initial commit of functional tests for SecretStores #5510

merged 16 commits into from
May 4, 2023

Conversation

youngbupark
Copy link

Description

Add functional tests for secretstores

Issue reference

radius-project/core-team#630

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Adds necessary unit tests for change
  • Adds necessary E2E tests for change
  • Unit tests passing
  • Extended the documentation / Created issue for it

@youngbupark youngbupark requested a review from a team as a code owner May 3, 2023 01:38
@github-actions
Copy link

github-actions bot commented May 3, 2023 •
edited
Loading

Test Results

2 515 tests  +13   2 508 ✔️ +13   1m 53s ⏱️ -1s
   230 suites ±  0          7 💤 ±  0 
       1 files   ±  0          0 ❌ ±  0 

Results for commit 55f5091. ± Comparison against base commit ff8052f.

This pull request removes 6 and adds 19 tests. Note that renamed tests count towards both. 
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/7c082eb5-d181-46f2-b022-4b547b875b7c
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/7c082eb5-d181-46f2-b022-4b547b875b7c#01
github.com/project-radius/radius/pkg/cli/cmd/recipe/register ‑ Test_Run/Register_recipe_with_an_existing_name.
github.com/project-radius/radius/pkg/corerp/frontend/controller/secretstores ‑ TestValidateRequest/resourceID_is_not_same
github.com/project-radius/radius/pkg/corerp/frontend/handler ‑ TestHandlers/http://localhost/api.ucp.dev/planes/radius/{planeName}/resourcegroups/testrg/providers/applications.core/environments/env0/recipe0/getmetadata?api-version=2022-03-15-privatepreview
github.com/project-radius/radius/pkg/corerp/frontend/handler ‑ TestHandlers/http://localhost/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/testrg/providers/applications.core/environments/env0/recipe0/getmetadata?api-version=2022-03-15-privatepreview

github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/8c10dff6-cbdb-413c-a439-2fe761bd4bdf
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/8c10dff6-cbdb-413c-a439-2fe761bd4bdf#01
github.com/project-radius/radius/pkg/cli/cmd/recipe/register ‑ Test_Run/Register_the_first_recipe
github.com/project-radius/radius/pkg/cli/cmd/recipe/show ‑ Test_Validate/Show_Command_without_LinkType
github.com/project-radius/radius/pkg/cli/cmd/recipe/unregister ‑ Test_Run/Unregister_recipe_from_the_environment/Unregister_recipe_with_linkType_doesn't_exist_in_the_environment
github.com/project-radius/radius/pkg/cli/cmd/recipe/unregister ‑ Test_Run/Unregister_recipe_from_the_environment/Unregister_recipe_with_same_name_for_different_resource_types.
github.com/project-radius/radius/pkg/cli/cmd/recipe/unregister ‑ Test_Validate/Unregister_Command_without_link_type
github.com/project-radius/radius/pkg/corerp/api/v20220315privatepreview ‑ TestConvertVersionedToDataModel/environmentresource-invalid-linktype.json
github.com/project-radius/radius/pkg/corerp/api/v20220315privatepreview ‑ TestInvalidLinkType
github.com/project-radius/radius/pkg/corerp/api/v20220315privatepreview ‑ TestRecipeConvertVersionedToDataModel
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 3, 2023

62.1

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 62.1 %
  • main branch coverage: 62.1 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@youngbupark youngbupark changed the title Add functional tests for secretstores Initial commit of functional tests for SecretStores May 3, 2023
@github-actions
Copy link

github-actions bot commented May 3, 2023

62.1

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 62.1 %
  • main branch coverage: 62.1 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@github-actions
Copy link

github-actions bot commented May 3, 2023

62.1

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 62.1 %
  • main branch coverage: 62.1 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@github-actions
Copy link

github-actions bot commented May 3, 2023

62.1

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 62.1 %
  • main branch coverage: 62.1 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@github-actions
Copy link

github-actions bot commented May 3, 2023

62.1

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 62.1 %
  • main branch coverage: 62.1 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@github-actions
Copy link

github-actions bot commented May 3, 2023

62.1

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 62.1 %
  • main branch coverage: 62.1 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@github-actions
Copy link

github-actions bot commented May 3, 2023

62.1

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 62.1 %
  • main branch coverage: 62.1 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

youngbupark
youngbupark commented May 3, 2023
View reviewed changes
test/functional/corerp/resources/testdata/test-tls-cert.parameters.json
"contentVersion": "1.0.0.0",
"parameters": {
"tlscrt": {
"value": "LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUZsakNDQTM0Q0NRQ0NsTTFHQVJoMTl6QU5CZ2txaGtpRzl3MEJBUXNGQURDQmpERUxNQWtHQTFVRUJoTUMKVlZNeEN6QUpCZ05WQkFnTUFsZEJNUkF3RGdZRFZRUUhEQWRTWldSdGIyNWtNUkl3RUFZRFZRUUtEQWxOYVdOeQpiM052Wm5ReERqQU1CZ05WQkFzTUJVRjZkWEpsTVJJd0VBWURWUVFEREFsc2IyTmhiR2h2YzNReEpqQWtCZ2txCmhraUc5dzBCQ1FFV0YzZHBiR3h6YldsMGFFQnRhV055YjNOdlpuUXVZMjl0TUI0WERUSXpNRFF5TkRBME1EY3kKTTFvWERUSTBNRFF5TXpBME1EY3lNMW93Z1l3eEN6QUpCZ05WQkFZVEFsVlRNUXN3Q1FZRFZRUUlEQUpYUVRFUQpNQTRHQTFVRUJ3d0hVbVZrYlc5dVpERVNNQkFHQTFVRUNnd0pUV2xqY205emIyWjBNUTR3REFZRFZRUUxEQVZCCmVuVnlaVEVTTUJBR0ExVUVBd3dKYkc5allXeG9iM04wTVNZd0pBWUpLb1pJaHZjTkFRa0JGaGQzYVd4c2MyMXAKZEdoQWJXbGpjbTl6YjJaMExtTnZiVENDQWlJd0RRWUpLb1pJaHZjTkFRRUJCUUFEZ2dJUEFEQ0NBZ29DZ2dJQgpBSy9RRFIrQ3Fhb2kvcTVZdjh2aWJjR3l4VkFFVVNYNlN6djFWenI1YWkwdERJVVZqdDlPakRSb295Ri9pMlpvCmtCbHUvenFhQzAvSUNtakxYcnB3Z21BQS9seVRMSDV3TThyRUVPeWdHV0EwcFAzZzY5LzdkQkJIY25sSVg2MjEKdGFKVXpjWk51Z2lRZ1dzdmhBTEttclBiUHdrbFJPVXozYXhUODdqaXBDWHdGd2hQQVpiUHZHL08vVDhkZzI3aQpMMmcreDJiWm5YWUJOc09XVWdiZnlML0dDOEF4eFpLNFdUTCtGQkJ0S1dCSUFjcnJzajBBZHIxQnlROTE3c01HCnJJcGdjSDNwR2prdzNtalFCVVJ2TUVmbjhiOEdUaTE0Sm9nWENITmNsSlQ5SXFUNFA4Z1RHc1I1U2VBdUoxTFoKSUx3UlBsNkZDSXc0bS9CSDl5bTYxbnBkSllneXpHNkNDWjFMNnhqaDBkN2xJL0lpRU1QMVJFRlB0eDVwSnh0Rgp0TFExVzhWdi83WjRma2ErK0kzSEF6anUvTXkrRHdKK1IvbEUvK2p0aDZWNVpnYzYwNENERm9waDM1ZzVlMFFzCnpLRldyNFhsdng1VjZwOW1rYUExS3JmT2ZPaHZuNllRVmFUcVlGRmc3QmJjVFdSRlBvTnB3VXJnWDRBcnhTVUsKZ2Q5NmpMcW9jZllFNDN3RWNkczMxUlNEd3RyTUpvQU5uK2R5SFg0WWJXL2ZLQkk2YnNDWkhlbjQ1SkFVV2lVeQpCU1pnYlRPOW12Y0JXcE5uRDFrbWhwRTBzMXVmVG4yUlkyeE1OMmo1b0VlaWY1UlQ3UGwzQzc0VVBuTjBDWFJiCms4dU9ydzdrWjROSERoOU83MFVEZGdDdzJtL3hWQTRVMWV0ZFo1L0ZUcWFuQWdNQkFBRXdEUVlKS29aSWh2Y04KQVFFTEJRQURnZ0lCQUt0amYzbDh5SUZQb2NiNjBWT29RalRzRXArZVU3N2hvZEZybzFGOExRN1pORGFPaTRjTgp1MUQ4cGJ5VWkvelhNcUxzTHRSc1o5Vmo0M1ZNNTZRWGVvZDJReXhNTW5XOStmbWxDWHpPSk53MXdIRTEwRXJhCkZDNTROZnE2WUkzQ1lFL2Y0RUwrSkhxMWNoOSs3VFJLdEF1YXZybVRtem1Wb2RwVSsvbWhOaUJQRWUvT0FmRU8KYndoYXVvcU83QjhVSmlnZ0R1ZmtnaW00Rm9BalFXdUtEUFdBM3VGNUNZK3lHS3ZvRUFHMEZuNjd0eWdCZkViRAozRklqbm9ZdmwxTGp2TjladklCeWw2Um5WWFg4SWluaHNVODdBajVaVGtYMXNaNVhZR1I3R3cxWFBXUmdOZGFFClZiazB4MnQybXAxRFZwL3kvaXhMTHJDMExtdURvcjhKRVNUNzJDWnhMck1JY3VKZWczd1dTK2J0TjRJUkt6cjIKUlFsWDIrQ1FkN2dTRllOQTAvWkd1R0NvM0JtZTFwMkRoRWt6dXd3ZVNDOUZ3MUwwOVJadGJzYzBUTEhDNG12ZgpTT2NZV0R1U3JMZGhqMjFubEV1dnlWeEZzR25VRDVlc1ErMktmbWE2Q2VnN3ZRQzJqS3FvbVoyOE53bW5ldHg3CmZ5UTFZNWVHbGVYS0ErczAyLzR6RVhHVjF5Z1d4azNDU0t4YSs0b0VjSnRFMWd4clNxc1NlK0ZnSURmdDhJQzEKUEVWVGQ4cE9UcjJnSGhCVkZJa0dvNUM2OEpLZTZuVi9PS1ROV24weExWWnZVSXJkQWhwcGNIL0pkN25tZFN0OApwWmtYSmtrTTdJUjljSENYSGtHRGwxZ3JnZkRTcWxhczRZNENsSmtpS2pzS3dQNzVSb2ROc0Q0SAotLS0tLUVORCBDRVJUSUZJQ0FURS0tLS0tCg=="
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willdavsmith You can pass the same parameters.json to bicep instead of hard-coded the secret.

@github-actions
Copy link

github-actions bot commented May 4, 2023

62.1

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 62.1 %
  • main branch coverage: 62.1 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@github-actions
Copy link

github-actions bot commented May 4, 2023

62.1

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 62.1 %
  • main branch coverage: 62.1 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@github-actions
Copy link

github-actions bot commented May 4, 2023

62.1

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 62.1 %
  • main branch coverage: 62.1 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@github-actions
Copy link

github-actions bot commented May 4, 2023

62.1

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 62.1 %
  • main branch coverage: 62.1 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@youngbupark youngbupark merged commit 1f88a65 into main May 4, 2023
@youngbupark youngbupark deleted the youngp/add-secret-test branch May 4, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytimocin ytimocin ytimocin left review comments

@willdavsmith willdavsmith willdavsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youngbupark @ytimocin @willdavsmith