Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cloud provider print conditional #5550

Merged
merged 1 commit into from
May 15, 2023

Conversation

AaronCrawfis
Copy link
Contributor

Description

Today we always print "Configuring Cloud providers"

This PR makes this conditional on if providers have been set.

Issue reference

Fixes: #5157

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Adds necessary unit tests for change
  • Adds necessary E2E tests for change
  • Unit tests passing
  • Extended the documentation / Created issue for it

@AaronCrawfis AaronCrawfis requested a review from a team as a code owner May 11, 2023 00:13
@github-actions
Copy link

github-actions bot commented May 11, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository project-radius/radius
Commit ref e1ba91b
Unique ID 8a90129afd
Image tag pr-8a90129afd
Click here to see the list of tools in the current test run
  • KinD: v0.18.0
  • Dapr: 1.10.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.0.0
  • recipe location radiusdev.azurecr.io/test/functional/corerp/recipes/<name>:pr-8a90129afd
  • appcore-rp test image location: radiusdev.azurecr.io/appcore-rp:pr-8a90129afd
  • ucp test image location: radiusdev.azurecr.io/ucpd:pr-8a90129afd

Test Status

✅ Building Radius and pushing container images for functional test...
✅ Test image build succeeded
✅ Test recipe publishing succeeded
✅ Starting samples functional tests...
✅ Starting ucp functional tests...
🚀 samples functional tests passed.
🚀 ucp functional tests passed.
✅ Starting corerp functional tests...
❌ Test tool installation for corerp failed. Please check the logs for more details.
❌ Failed to install Radius for corerp functional test. Please check the logs for more details.
❌ corerp functional test failed. Please check the logs for more details.
✅ Starting corerp functional tests...
🚀 corerp functional tests passed.

@github-actions
Copy link

Test Results

2 528 tests  ±0   2 521 ✔️ ±0   1m 56s ⏱️ +3s
   230 suites ±0          7 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit e1ba91b. ± Comparison against base commit 0ad6b50.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/b8c18410-df7b-41d4-accf-5d210e24efff
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/b8c18410-df7b-41d4-accf-5d210e24efff#01
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/0fd7273f-91db-4afd-a177-1efef5922fc9
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/0fd7273f-91db-4afd-a177-1efef5922fc9#01

@github-actions
Copy link

62.4

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 62.4 %
  • main branch coverage: 62.4 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@AaronCrawfis AaronCrawfis merged commit a5d7499 into main May 15, 2023
@AaronCrawfis AaronCrawfis deleted the aacrawfi/fix-providers-print branch May 15, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rad init --dev shows cloud provider line
3 participants