Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create one issue for the scheduled functional test failure #5552

Merged
merged 2 commits into from
May 11, 2023

Conversation

youngbupark
Copy link

Description

The current scheduled functional test can create multiple bug issue when the test is failed because it creates the issue per job. This PR is to create only one bug issue and improve the bug info.

Issue reference

Fixes: #issue_number

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Adds necessary unit tests for change
  • Adds necessary E2E tests for change
  • Unit tests passing
  • Extended the documentation / Created issue for it

@youngbupark youngbupark requested a review from a team as a code owner May 11, 2023 09:05
@youngbupark youngbupark changed the title Create one functional test failure bug Create one functional test failure issue May 11, 2023
@github-actions
Copy link

github-actions bot commented May 11, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository project-radius/radius
Commit ref d545eec
Unique ID c29fa99fca
Image tag pr-c29fa99fca
Click here to see the list of tools in the current test run
  • KinD: v0.18.0
  • Dapr: 1.10.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.0.0
  • recipe location radiusdev.azurecr.io/test/functional/corerp/recipes/<name>:pr-c29fa99fca
  • appcore-rp test image location: radiusdev.azurecr.io/appcore-rp:pr-c29fa99fca
  • ucp test image location: radiusdev.azurecr.io/ucpd:pr-c29fa99fca

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples functional tests...
⌛ Starting ucp functional tests...
⌛ Starting corerp functional tests...
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ corerp functional tests succeeded

@youngbupark
Copy link
Author

@rynowak @AaronCrawfis Please feel free to modify the message in this PR accordingly. Then please merge it if you like it. This will be the last PR and I will be offline by 5/23 :)

@youngbupark youngbupark changed the title Create one functional test failure issue Create one issue for the scheduled functional test failure May 11, 2023
@github-actions
Copy link

Test Results

2 538 tests  ±0   2 531 ✔️ ±0   1m 56s ⏱️ +2s
   230 suites ±0          7 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit d545eec. ± Comparison against base commit bb335a1.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/5e340cab-77f3-4fb9-b665-77a5fe803e78
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/5e340cab-77f3-4fb9-b665-77a5fe803e78#01
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/3fe66ace-3592-47be-a2d5-b19f3706f455
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/3fe66ace-3592-47be-a2d5-b19f3706f455#01

@github-actions
Copy link

62.5

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 62.5 %
  • main branch coverage: 62.5 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@youngbupark youngbupark merged commit bb1aa8d into main May 11, 2023
@youngbupark youngbupark deleted the youngp/reduce-noise branch May 11, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants