Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused files. #5570

Merged
merged 1 commit into from
May 17, 2023
Merged

Remove unused files. #5570

merged 1 commit into from
May 17, 2023

Conversation

vinayada1
Copy link
Contributor

@vinayada1 vinayada1 commented May 17, 2023

Description

These files are unused and instead the same files are being generated in the v20220315 folder. Removing these. They are causing problems for replacing copyright notice

Issue reference

Fixes: #issue_number

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Adds necessary unit tests for change
  • Adds necessary E2E tests for change
  • Unit tests passing
  • Extended the documentation / Created issue for it

@vinayada1 vinayada1 requested a review from a team as a code owner May 17, 2023 18:49
@github-actions
Copy link

github-actions bot commented May 17, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository project-radius/radius
Commit ref 7877120
Unique ID d5dfe03175
Image tag pr-d5dfe03175
Click here to see the list of tools in the current test run
  • KinD: v0.18.0
  • Dapr: 1.10.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.0.0
  • recipe location radiusdev.azurecr.io/test/functional/corerp/recipes/<name>:pr-d5dfe03175
  • appcore-rp test image location: radiusdev.azurecr.io/appcore-rp:pr-d5dfe03175
  • ucp test image location: radiusdev.azurecr.io/ucpd:pr-d5dfe03175

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting samples functional tests...
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
❌ corerp functional test failed. Please check the logs for more details
⌛ Starting corerp functional tests...
✅ corerp functional tests succeeded

@github-actions
Copy link

Test Results

2 549 tests  ±0   2 542 ✔️ ±0   1m 53s ⏱️ -11s
   229 suites  - 1          7 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit 7877120. ± Comparison against base commit a6f848d.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/56b35400-eb16-46c6-84be-536015921da2
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/56b35400-eb16-46c6-84be-536015921da2#01
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/c59702fc-aeba-4ed4-927f-0f09b62ab844
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/c59702fc-aeba-4ed4-927f-0f09b62ab844#01

@github-actions
Copy link

62.6

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 62.6 %
  • main branch coverage: 62.6 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@vinayada1 vinayada1 merged commit 3300c29 into main May 17, 2023
@vinayada1 vinayada1 deleted the removefiles branch May 17, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants