Enable repository_dispatcher trigger in functional test" #5640

vinayada1 · 2023-06-05T18:38:05Z

Trigger e2e tests on repository_dispatch event

Description

Trigger e2e tests on repository_dispatch event. The remaining changes to create the repository_dispatch event will be made in a separate PR for testing purpose

#5618

Fixes: #issue_number

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Adds necessary unit tests for change
Adds necessary E2E tests for change
Unit tests passing
Extended the documentation / Created issue for it

Auto-generated summary

`🤖 Generated by Copilot at 9485678`

Summary

🧪🍴📥

Enable functional-test workflow to run on external pull requests from forks. Add step to read e2e-test event payload and set fork branch and issue number variables.

e2e-test triggers the doom
From the forks of hell they come
Reading the payload of the beast
Setting the variables for the feast

Walkthrough

Add a new trigger for the functional-test workflow to run end-to-end tests on pull requests from forks (link)
Add a new step to the functional-test workflow to read the custom payload of the repository_dispatch event and set environment variables for the forked pull request (link)

github-actions · 2023-06-05T18:41:30Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	project-radius/radius
Commit ref	`9485678`
Unique ID	e403f30463
Image tag	pr-e403f30463

Click here to see the list of tools in the current test run

KinD: v0.18.0
Dapr: 1.10.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.0.0
recipe location radiusdev.azurecr.io/test/functional/corerp/recipes/<name>:pr-e403f30463
appcore-rp test image location: radiusdev.azurecr.io/appcore-rp:pr-e403f30463
ucp test image location: radiusdev.azurecr.io/ucpd:pr-e403f30463

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp functional tests...
⌛ Starting samples functional tests...
⌛ Starting ucp functional tests...
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
❌ corerp functional test failed. Please check the logs for more details

github-actions · 2023-06-05T18:49:06Z

Test Results

2 750 tests ±0 2 743 ✔️ ±0 1m 54s ⏱️ -1s
  242 suites ±0       7 💤 ±0
      1 files ±0       0 ❌ ±0

Results for commit c943da8. ± Comparison against base commit 381c73f.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.

github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/e12ca2a5-6afb-4ff1-be46-1a95f7faa74f
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/e12ca2a5-6afb-4ff1-be46-1a95f7faa74f#01

github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/f06b441f-f57e-4555-8d4f-31a3e36a4da4
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/f06b441f-f57e-4555-8d4f-31a3e36a4da4#01

♻️ This comment has been updated with latest results.

github-actions · 2023-06-05T18:49:18Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 64.9 %
main branch coverage: 64.9 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

youngbupark · 2023-06-05T18:54:12Z

@vinayada1 can you please change the title to be more specific? for example, "Enable repository_dispatcher trigger in functional test"

youngbupark

Before merging the PR, please change the title to be more specific. e.g. Enable repository_dispatch trigger for functional test

rynowak · 2023-06-05T20:40:46Z

.github/workflows/functional-test.yaml

+          github-token: ${{ secrets.GH_RAD_CI_BOT_PAT }}
+          script: |
+            const testPayload = context.payload.client_payload;
+            if (testPayload && testPayload.command == "ok-to-test") {


Suggested change

if (testPayload && testPayload.command == "ok-to-test") {

if (testPayload && testPayload.command === "ok-to-test") {

What's the purpose of checking the command here? It should have already been checked before this workflow starts right?

Yes it will be checked before as well. Just to make sure we are processing the right repository event and if we want to add more commands later

.github/workflows/functional-test.yaml

github-actions · 2023-06-05T21:46:29Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	project-radius/radius
Commit ref	`16adee3`
Unique ID	a73b6294bd
Image tag	pr-a73b6294bd

Click here to see the list of tools in the current test run

KinD: v0.18.0
Dapr: 1.10.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.0.0
recipe location radiusdev.azurecr.io/test/functional/corerp/recipes/<name>:pr-a73b6294bd
appcore-rp test image location: radiusdev.azurecr.io/appcore-rp:pr-a73b6294bd
ucp test image location: radiusdev.azurecr.io/ucpd:pr-a73b6294bd

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting samples functional tests...
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ corerp functional tests succeeded

Trigger e2e tests on repository_dispatch event

github-actions · 2023-06-05T21:51:41Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	project-radius/radius
Commit ref	`c943da8`
Unique ID	2bc0f1f359
Image tag	pr-2bc0f1f359

Click here to see the list of tools in the current test run

KinD: v0.18.0
Dapr: 1.10.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.0.0
recipe location radiusdev.azurecr.io/test/functional/corerp/recipes/<name>:pr-2bc0f1f359
appcore-rp test image location: radiusdev.azurecr.io/appcore-rp:pr-2bc0f1f359
ucp test image location: radiusdev.azurecr.io/ucpd:pr-2bc0f1f359

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp functional tests...
⌛ Starting corerp functional tests...
⌛ Starting samples functional tests...
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ corerp functional tests succeeded

github-actions · 2023-06-05T22:04:04Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 64.9 %
main branch coverage: 64.9 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

vinayada1 requested a review from a team as a code owner June 5, 2023 18:38

youngbupark approved these changes Jun 5, 2023

View reviewed changes

rynowak reviewed Jun 5, 2023

View reviewed changes

.github/workflows/functional-test.yaml Outdated Show resolved Hide resolved

rynowak reviewed Jun 5, 2023

View reviewed changes

.github/workflows/functional-test.yaml Show resolved Hide resolved

vinayada1 added 2 commits June 5, 2023 14:50

trigger tests on PR comment - Part 1

d60ae39

Trigger e2e tests on repository_dispatch event

fix review comments

c943da8

vinayada1 force-pushed the ok-to-test-part1 branch from 16adee3 to c943da8 Compare June 5, 2023 21:51

vinayada1 merged commit f136ecf into main Jun 5, 2023

vinayada1 deleted the ok-to-test-part1 branch June 5, 2023 23:42

vinayada1 changed the title ~~trigger tests on PR comment - Part 1~~ Enable repository_dispatcher trigger in functional test" Jun 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable repository_dispatcher trigger in functional test" #5640

Enable repository_dispatcher trigger in functional test" #5640

vinayada1 commented Jun 5, 2023 •

edited by ghost

Loading

github-actions bot commented Jun 5, 2023 •

edited

Loading

github-actions bot commented Jun 5, 2023 •

edited

Loading

github-actions bot commented Jun 5, 2023

youngbupark commented Jun 5, 2023

youngbupark left a comment

rynowak Jun 5, 2023

rynowak Jun 5, 2023

vinayada1 Jun 5, 2023

github-actions bot commented Jun 5, 2023 •

edited

Loading

github-actions bot commented Jun 5, 2023 •

edited

Loading

github-actions bot commented Jun 5, 2023

	if (testPayload && testPayload.command == "ok-to-test") {
	if (testPayload && testPayload.command === "ok-to-test") {

Enable repository_dispatcher trigger in functional test" #5640

Enable repository_dispatcher trigger in functional test" #5640

Conversation

vinayada1 commented Jun 5, 2023 • edited by ghost Loading

Description

Checklist

Auto-generated summary

🤖 Generated by Copilot at 9485678

Summary

Walkthrough

github-actions bot commented Jun 5, 2023 • edited Loading

Radius functional test overview

Test Status

github-actions bot commented Jun 5, 2023 • edited Loading

Test Results

github-actions bot commented Jun 5, 2023

youngbupark commented Jun 5, 2023

youngbupark left a comment

Choose a reason for hiding this comment

rynowak Jun 5, 2023

Choose a reason for hiding this comment

rynowak Jun 5, 2023

Choose a reason for hiding this comment

vinayada1 Jun 5, 2023

Choose a reason for hiding this comment

github-actions bot commented Jun 5, 2023 • edited Loading

Radius functional test overview

Test Status

github-actions bot commented Jun 5, 2023 • edited Loading

Radius functional test overview

Test Status

github-actions bot commented Jun 5, 2023

vinayada1 commented Jun 5, 2023 •

edited by ghost

Loading

`🤖 Generated by Copilot at 9485678`

github-actions bot commented Jun 5, 2023 •

edited

Loading

github-actions bot commented Jun 5, 2023 •

edited

Loading

github-actions bot commented Jun 5, 2023 •

edited

Loading

github-actions bot commented Jun 5, 2023 •

edited

Loading