Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix development configuration #5679

Merged
merged 4 commits into from
Jun 9, 2023
Merged

Fix development configuration #5679

merged 4 commits into from
Jun 9, 2023

Conversation

rynowak
Copy link
Contributor

@rynowak rynowak commented Jun 8, 2023 •
edited by ghost
Loading

Somehow this file ended up with a merge-marker inside.

Auto-generated summary

🤖 Generated by Copilot at 842d9b1

Summary

🗑️🐛🔀

Fix a merge conflict marker in link-self-hosted.yaml. This file defines the configuration for linking self-hosted Radius instances to the cloud service.

Merge conflict gone
yaml file is now clean
Autumn leaves no trace

Walkthrough

  • Remove merge conflict marker from link-self-hosted.yaml (link)

@rynowak
Fix development configuration
842d9b1 
Somehow this file ended up with a merge-marker inside.
@rynowak rynowak requested a review from a team as a code owner June 8, 2023 19:15
@github-actions
Copy link

github-actions bot commented Jun 8, 2023 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository project-radius/radius
Commit ref 842d9b1
Unique ID 8f82b6092d
Image tag pr-8f82b6092d
Click here to see the list of tools in the current test run
  • KinD: v0.18.0
  • Dapr: 1.10.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.0.0
  • recipe location radiusdev.azurecr.io/test/functional/corerp/recipes/<name>:pr-8f82b6092d
  • appcore-rp test image location: radiusdev.azurecr.io/appcore-rp:pr-8f82b6092d
  • ucp test image location: radiusdev.azurecr.io/ucpd:pr-8f82b6092d

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples functional tests...
⌛ Starting corerp functional tests...
⌛ Starting ucp functional tests...
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ corerp functional tests succeeded

@github-actions
Copy link

github-actions bot commented Jun 8, 2023 •
edited
Loading

Test Results

2 684 tests  ±0   2 677 ✔️ ±0   1m 57s ⏱️ +2s
   239 suites ±0          7 💤 ±0 
       1 files   ±0          0 ❌ ±0 

Results for commit c1222ce. ± Comparison against base commit 9d062aa.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both. 
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/ce356501-b871-4141-b906-2c3d156cfc4d
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/ce356501-b871-4141-b906-2c3d156cfc4d#01

github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/7c2391b9-c890-41f8-96e6-ff9e4815ba25
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/7c2391b9-c890-41f8-96e6-ff9e4815ba25#01

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

64.7

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 64.7 %
  • main branch coverage: 64.7 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@github-actions
Copy link

github-actions bot commented Jun 8, 2023 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository project-radius/radius
Commit ref f093bef
Unique ID db1ba5278a
Image tag pr-db1ba5278a
Click here to see the list of tools in the current test run
  • KinD: v0.18.0
  • Dapr: 1.10.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.0.0
  • recipe location radiusdev.azurecr.io/test/functional/corerp/recipes/<name>:pr-db1ba5278a
  • appcore-rp test image location: radiusdev.azurecr.io/appcore-rp:pr-db1ba5278a
  • ucp test image location: radiusdev.azurecr.io/ucpd:pr-db1ba5278a

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp functional tests...
⌛ Starting samples functional tests...
⌛ Starting ucp functional tests...
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ corerp functional tests succeeded

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

64.7

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 64.7 %
  • main branch coverage: 64.7 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@github-actions
Copy link

github-actions bot commented Jun 8, 2023 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository project-radius/radius
Commit ref ea7f6bf
Unique ID a8c8a79f1c
Image tag pr-a8c8a79f1c
Click here to see the list of tools in the current test run
  • KinD: v0.18.0
  • Dapr: 1.10.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.0.0
  • recipe location radiusdev.azurecr.io/test/functional/corerp/recipes/<name>:pr-a8c8a79f1c
  • appcore-rp test image location: radiusdev.azurecr.io/appcore-rp:pr-a8c8a79f1c
  • ucp test image location: radiusdev.azurecr.io/ucpd:pr-a8c8a79f1c

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp functional tests...
⌛ Starting ucp functional tests...
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ corerp functional tests succeeded

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

64.7

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 64.7 %
  • main branch coverage: 64.7 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@github-actions
Copy link

github-actions bot commented Jun 9, 2023 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository project-radius/radius
Commit ref c1222ce
Unique ID fa7d805f46
Image tag pr-fa7d805f46
Click here to see the list of tools in the current test run
  • KinD: v0.18.0
  • Dapr: 1.10.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.0.0
  • recipe location radiusdev.azurecr.io/test/functional/corerp/recipes/<name>:pr-fa7d805f46
  • appcore-rp test image location: radiusdev.azurecr.io/appcore-rp:pr-fa7d805f46
  • ucp test image location: radiusdev.azurecr.io/ucpd:pr-fa7d805f46

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting samples functional tests...
❌ Test tool installation for corerp failed. Please check the logs for more details
❌ Failed to install Radius for corerp functional test. Please check the logs for more details
❌ corerp functional test failed. Please check the logs for more details
❌ Test tool installation for ucp failed. Please check the logs for more details
❌ Failed to install Radius for ucp functional test. Please check the logs for more details
❌ ucp functional test failed. Please check the logs for more details
❌ Test tool installation for samples failed. Please check the logs for more details
❌ Failed to install Radius for samples functional test. Please check the logs for more details
❌ samples functional test failed. Please check the logs for more details

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

64.5

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 64.5 %
  • main branch coverage: 64.5 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@rynowak
Copy link
Contributor Author

rynowak commented Jun 9, 2023

Bypassing build failures. This file is not used in any tests

@rynowak rynowak merged commit 7bb15fd into main Jun 9, 2023
@rynowak rynowak deleted the rynowak/fix-config branch June 9, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronCrawfis AaronCrawfis AaronCrawfis approved these changes

@willdavsmith willdavsmith willdavsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rynowak @willdavsmith @AaronCrawfis