Fix for updating the dapr bicep files to remove mode. #5688
Conversation
|
You are editing files which require a docs update. Please ensure you've made the appropriate changes to the docs and submitted a PR.
For more information on contributing to docs please visit https://docs.radapp.dev/contributing/docs/. |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Test Results2 687 tests ±0 2 680 ✔️ ±0 1m 59s ⏱️ +2s Results for commit 6bd12c9. ± Comparison against base commit 02f19d9. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
For the detailed report, please go to
|
vishwahiremat
changed the title
This comment has been minimized.
This comment has been minimized.
|
For the detailed report, please go to
|
|
⌛ Building Radius and pushing container images for functional tests... ✅ Container images build succeeded |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
|
For the detailed report, please go to
|
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
|
For the detailed report, please go to
|
| @@ -3,7 +3,7 @@ | |||
| "name": "daprSecretStore0", | |||
| "type": "Applications.Link/daprSecretStores", | |||
| "properties": { | |||
| "mode": "values", | |||
| "resourceProvisioning": "manual", | |||
There was a problem hiding this comment.
Any idea how we missed this before? Is this possible because of #5501
There was a problem hiding this comment.
its because "resourceProvisioning" is not a required property and "version" is a valid property on resourceProvisioning type recipe as well.
| @@ -9,9 +9,6 @@ param magpieImage string | |||
| @description('Specifies the port for the container resource.') | |||
| param magpiePort int = 3000 | |||
|
|
|||
| @description('Specifies the environment for resources.') | |||
| param environment string = 'test' | |||
There was a problem hiding this comment.
yes, it was not used
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
|
For the detailed report, please go to
|
# Description Added cahnges to remove mode for dapr secret store bicep files. ## Issue reference <!-- We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation. --> Fixes: #issue_number ## Checklist Please make sure you've completed the relevant tasks for this PR, out of the following list: * [x] Code compiles correctly * [ ] Adds necessary unit tests for change * [ ] Adds necessary E2E tests for change * [x] Unit tests passing * [ ] Extended the documentation / Created issue for it ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at 997d47d</samp> ### Summary 📝🐹📄 <!-- 1. 📝 - This emoji represents a change related to documentation, comments, or descriptions. It can be used to indicate that a change improves the clarity, accuracy, or completeness of the documentation for a model, type, schema, or API. 2. 🐹 - This emoji represents a change related to the Go language or code. It can be used to indicate that a change affects the generated Go code for a package, module, or service. It may also imply that the change is specific to the Go language or platform. 3. 📄 - This emoji represents a change related to the OpenAPI specification or file. It can be used to indicate that a change affects the generated OpenAPI JSON or YAML file for an API version, service, or model. It may also imply that the change is related to the RESTful or HTTP aspects of the API. --> Add a period to the doc comment for the `DaprSecretStoreProperties` model in the `Applications.Link` namespace. This improves the documentation and consistency of the cadl models and the generated Go and OpenAPI files. > _`DaprSecretStore`_ > _Adding periods for docs_ > _Winter of cadl_ ### Walkthrough * Add a period to the doc comment and description of the `DaprSecretStoreProperties` model and its generated counterparts in Go and OpenAPI ([link](https://github.com/project-radius/radius/pull/5688/files?diff=unified&w=0#diff-956ed27870b031f49618a9b6a8042d476f99d7e3138e4657581ffaeeba648ee6L44-R44), [link](https://github.com/project-radius/radius/pull/5688/files?diff=unified&w=0#diff-061124b001db64301047fda4f1c0c2f1d4b947a0c0811aedbd975f9ee690c855L232-R232), [link](https://github.com/project-radius/radius/pull/5688/files?diff=unified&w=0#diff-a01be26add36174c850eed56a34c2ba92a92c5d4a1795dded33a573263b846a6L1932-R1932))
Description
Added cahnges to remove mode for dapr secret store bicep files.
Issue reference
Fixes: #issue_number
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Auto-generated summary
🤖 Generated by Copilot at 997d47d
Summary
📝🐹📄
Add a period to the doc comment for the
DaprSecretStorePropertiesmodel in theApplications.Linknamespace. This improves the documentation and consistency of the cadl models and the generated Go and OpenAPI files.Walkthrough
DaprSecretStorePropertiesmodel and its generated counterparts in Go and OpenAPI (link, link, link)