Fix test failure issue creation #5710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok-to-test |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
AaronCrawfis
approved these changes
Jun 13, 2023
AaronCrawfis
approved these changes
Jun 13, 2023
Test Results2 699 tests ±0 2 692 ✔️ ±0 1m 56s ⏱️ -1s Results for commit 1f35b10. ± Comparison against base commit 6357cb7. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both. |
|
For the detailed report, please go to
|
nithyatsu
pushed a commit
that referenced
this pull request
Jun 21, 2023
# Description GitHub Team cannot be `assignees`. So issue creation is failing now. ## Issue reference <!-- We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation. --> Fixes: #issue_number ## Checklist Please make sure you've completed the relevant tasks for this PR, out of the following list: * [ ] Code compiles correctly * [ ] Adds necessary unit tests for change * [ ] Adds necessary E2E tests for change * [ ] Unit tests passing * [ ] Extended the documentation / Created issue for it ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at 1f35b10</samp> ### Summary 🚫🧹🤷 <!-- 1. 🚫 - This emoji conveys the idea of removing or deleting something, which is what happened to the `assignees` field. It can also imply a negative or unwanted outcome, which might be the case if the issue is not assigned to anyone who can fix it. 2. 🧹 - This emoji suggests the idea of cleaning or simplifying something, which is the intention behind omitting the `assignees` field. It can also imply a positive or desirable outcome, which might be the case if the workflow configuration is easier to read and maintain. 3. 🤷 - This emoji expresses the idea of uncertainty or indifference, which might be the attitude of the workflow creator or the issue creator towards the `assignees` field. It can also imply a lack of responsibility or accountability, which might be the case if the issue is not assigned to anyone who can fix it. --> Removed `assignees` field from `create-issue` step in `.github/workflows/functional-test.yaml`. This simplifies the workflow and avoids assigning issues to a specific team. > _`assignees` gone_ > _workflow config simplified_ > _autumn leaves fall fast_ ### Walkthrough * Remove `assignees` field from `create-issue` step in `functional-test` workflow ([link](https://github.com/project-radius/radius/pull/5710/files?diff=unified&w=0#diff-c79f364a9293abaaa8595776b74674e24bec6287834e63ab8aa7aec6a42f0dbcL525)). This simplifies the workflow configuration and avoids assigning issues to a specific team. The workflow runs functional tests on every pull request to the `main` branch of the `.github/workflows/functional-test.yaml` file and creates an issue if any test fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GitHub Team cannot be
assignees. So issue creation is failing now.Issue reference
Fixes: #issue_number
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Auto-generated summary
🤖 Generated by Copilot at 1f35b10
Summary
🚫🧹🤷
Removed
assigneesfield fromcreate-issuestep in.github/workflows/functional-test.yaml. This simplifies the workflow and avoids assigning issues to a specific team.Walkthrough
assigneesfield fromcreate-issuestep infunctional-testworkflow (link). This simplifies the workflow configuration and avoids assigning issues to a specific team. The workflow runs functional tests on every pull request to themainbranch of the.github/workflows/functional-test.yamlfile and creates an issue if any test fails.