Fix functional test by dispatch trigger #5712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngbupark
changed the title
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
AaronCrawfis
approved these changes
Jun 13, 2023
Test Results2 699 tests ±0 2 692 ✔️ ±0 1m 55s ⏱️ -5s Results for commit 88661c7. ± Comparison against base commit dc49de4. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
For the detailed report, please go to
|
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
|
For the detailed report, please go to
|
nithyatsu
pushed a commit
that referenced
this pull request
Jun 21, 2023
# Description We need to use javascript syntax for github-actions, not bash commands. ## Issue reference <!-- We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation. --> Fixes: #issue_number ## Checklist Please make sure you've completed the relevant tasks for this PR, out of the following list: * [ ] Code compiles correctly * [ ] Adds necessary unit tests for change * [ ] Adds necessary E2E tests for change * [ ] Unit tests passing * [ ] Extended the documentation / Created issue for it ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at 254cf6f</samp> ### Summary 🛠️🧪🔄 <!-- 1. 🛠️ - This emoji represents fixing or repairing something, which is what the step did by using the latest action and the `fs` module to avoid errors and bugs. 2. 🧪 - This emoji represents testing or experimenting, which is what the functional-test workflow does by running tests on different platforms and browsers. 3. 🔄 - This emoji represents updating or refreshing something, which is what the step did by using the latest version of the action and the `fs` module to ensure compatibility and performance. --> Improved the functional-test workflow for pull requests by using a newer action and a built-in module. This change affects the `.github/workflows/functional-test.yaml` file. > _We are the functional-test warriors_ > _We use the latest `github-script` to fight_ > _We set up the checkout target with `fs`_ > _We test the pull requests in the night_ ### Walkthrough * Simplify the `uses` field of the `Set up checkout target (repository_dispatch)` step to use the major version tag of the `actions/github-script` action ([link](https://github.com/project-radius/radius/pull/5712/files?diff=unified&w=0#diff-c79f364a9293abaaa8595776b74674e24bec6287834e63ab8aa7aec6a42f0dbcL91-R91)) * Fix the environment variable setting for Windows runners by using the `fs` module instead of the `echo` command in the `Set up checkout target (repository_dispatch)` step ([link](https://github.com/project-radius/radius/pull/5712/files?diff=unified&w=0#diff-c79f364a9293abaaa8595776b74674e24bec6287834e63ab8aa7aec6a42f0dbcL97-R103)) * Use the `testPayload` object to get the pull request information for the `repository_dispatch` event in the `Set up checkout target (repository_dispatch)` step ([link](https://github.com/project-radius/radius/pull/5712/files?diff=unified&w=0#diff-c79f364a9293abaaa8595776b74674e24bec6287834e63ab8aa7aec6a42f0dbcL97-R103))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to use javascript syntax for github-actions, not bash commands.
Issue reference
Fixes: #issue_number
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Auto-generated summary
🤖 Generated by Copilot at 254cf6f
Summary
🛠️🧪🔄
Improved the functional-test workflow for pull requests by using a newer action and a built-in module. This change affects the
.github/workflows/functional-test.yamlfile.Walkthrough
usesfield of theSet up checkout target (repository_dispatch)step to use the major version tag of theactions/github-scriptaction (link)fsmodule instead of theechocommand in theSet up checkout target (repository_dispatch)step (link)testPayloadobject to get the pull request information for therepository_dispatchevent in theSet up checkout target (repository_dispatch)step (link)