Fix for Datamodel conversion error #5732
Conversation
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Test Results2 716 tests +2 2 709 ✔️ +2 2m 2s ⏱️ ±0s Results for commit d467693. ± Comparison against base commit 6d16267. This pull request removes 2 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
For the detailed report, please go to
|
There was a problem hiding this comment.
Let's have a meeting to make sure that all properties are correct in terms of being required or not. cc/ @AaronCrawfis @rynowak @sk593
| @@ -80,7 +80,7 @@ type SqlDatabaseProperties struct { | |||
| // List of the resource IDs that support the SqlDB resource | |||
| Resources []*linkrp.ResourceReference `json:"resources,omitempty"` | |||
| // Username of the Sql database | |||
| Username string `json:"username"` | |||
| Username string `json:"username,omitempty"` | |||
There was a problem hiding this comment.
Do we want to have a meeting to discuss which of these properties should be required? cc/ @AaronCrawfis @rynowak
This comment has been minimized.
This comment has been minimized.
|
For the detailed report, please go to
|
|
⌛ Building Radius and pushing container images for functional tests... ✅ Container images build succeeded |
# Description Added OmitEmpty property on field username. ## Issue reference Fixes: #issue_number ## Checklist Please make sure you've completed the relevant tasks for this PR, out of the following list: * [x] Code compiles correctly * [x] Adds necessary unit tests for change * [ ] Adds necessary E2E tests for change * [x] Unit tests passing * [ ] Extended the documentation / Created issue for it ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at 1e829c7</samp> ### Summary :label::sparkles::white_check_mark: <!-- 1. :label: - This emoji represents the addition of the `omitempty` tag to the JSON annotations, which is a change in the labeling or metadata of the fields. 2. :sparkles: - This emoji represents the enhancement or improvement of the functionality of the Mongo and SQL database types, which allows for more flexibility and options in creating databases without usernames. 3. :white_check_mark: - This emoji represents the addition of new test cases, which is a change in the quality or reliability of the code. --> This pull request adds support for the `2022-03-15-privatepreview` API version for SQL database converter tests and makes the `Username` field optional for both SQL and Mongo database properties. > _Sing, O Muse, of the skillful engineers who wrought_ > _With nimble fingers and keen minds the code that brought_ > _To life the databases of Mongo and of SQL_ > _And gave them properties of `Username` optional._ ### Walkthrough * Make `Username` field optional for SQL and Mongo database properties ([link](https://github.com/project-radius/radius/pull/5732/files?diff=unified&w=0#diff-6d8a82349409a90b33eabb56f84502b98614136152d60fd7a0be2ed82b9edb11L58-R58), [link](https://github.com/project-radius/radius/pull/5732/files?diff=unified&w=0#diff-e781d4869cd1a8e6df1c16cd083e5a8234b1436e51d2a052486b438ee01aa583L83-R83)) * Add test cases for converting SQL database resource and secrets between versioned API and data model representations ([link](https://github.com/project-radius/radius/pull/5732/files?diff=unified&w=0#diff-2adf71fc09b0bffd2b6e29ce11a8099ea530d901aa41c159ec8402f7f9acb1d6R80-R84), [link](https://github.com/project-radius/radius/pull/5732/files?diff=unified&w=0#diff-2adf71fc09b0bffd2b6e29ce11a8099ea530d901aa41c159ec8402f7f9acb1d6R124-R129))
Description
Added OmitEmpty property on field username.
Issue reference
Fixes: #issue_number
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Auto-generated summary
🤖 Generated by Copilot at 1e829c7
Summary
🏷️✨✅
This pull request adds support for the
2022-03-15-privatepreviewAPI version for SQL database converter tests and makes theUsernamefield optional for both SQL and Mongo database properties.Walkthrough
Usernamefield optional for SQL and Mongo database properties (link, link)